From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763109AbbA3Sei (ORCPT ); Fri, 30 Jan 2015 13:34:38 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35875 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762920AbbA3Seg (ORCPT ); Fri, 30 Jan 2015 13:34:36 -0500 Date: Fri, 30 Jan 2015 10:34:16 -0800 From: tip-bot for Namhyung Kim Message-ID: Cc: a.p.zijlstra@chello.nl, fweisbec@gmail.com, linux-kernel@vger.kernel.org, eranian@google.com, mingo@kernel.org, tglx@linutronix.de, acme@redhat.com, dsahern@gmail.com, jolsa@redhat.com, hpa@zytor.com, andi@firstfloor.org, adrian.hunter@intel.com, namhyung@kernel.org Reply-To: mingo@kernel.org, eranian@google.com, dsahern@gmail.com, tglx@linutronix.de, acme@redhat.com, a.p.zijlstra@chello.nl, fweisbec@gmail.com, linux-kernel@vger.kernel.org, hpa@zytor.com, andi@firstfloor.org, jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com In-Reply-To: <1422518843-25818-40-git-send-email-namhyung@kernel.org> References: <1422518843-25818-40-git-send-email-namhyung@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf symbols: Convert lseek + read to pread Git-Commit-ID: c52686f9f888d23ca72f1309e86af8e91d075697 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c52686f9f888d23ca72f1309e86af8e91d075697 Gitweb: http://git.kernel.org/tip/c52686f9f888d23ca72f1309e86af8e91d075697 Author: Namhyung Kim AuthorDate: Thu, 29 Jan 2015 17:02:01 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 29 Jan 2015 17:02:01 -0300 perf symbols: Convert lseek + read to pread When dso_cache__read() is called, it reads data from the given offset using lseek + normal read syscall. It can be combined to a single pread syscall. Signed-off-by: Namhyung Kim Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Frederic Weisbecker Cc: Jiri Olsa Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/1422518843-25818-40-git-send-email-namhyung@kernel.org [ Fixed it up when cherry picking it from the multi threaded patchkit ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/dso.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 45be944..c2f7d3b 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -532,12 +532,8 @@ dso_cache__read(struct dso *dso, u64 offset, u8 *data, ssize_t size) break; cache_offset = offset & DSO__DATA_CACHE_MASK; - ret = -EINVAL; - if (-1 == lseek(dso->data.fd, cache_offset, SEEK_SET)) - break; - - ret = read(dso->data.fd, cache->data, DSO__DATA_CACHE_SIZE); + ret = pread(dso->data.fd, cache->data, DSO__DATA_CACHE_SIZE, cache_offset); if (ret <= 0) break;