From: tip-bot for Arnd Bergmann <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, arnd@arndb.de, hpa@zytor.com,
davem@davemloft.net, gregory.clement@free-electrons.com,
rcochran@linutronix.de, linux-kernel@vger.kernel.org,
marc.zyngier@arm.com, peterz@infradead.org, tglx@linutronix.de,
torvalds@linux-foundation.org, jason@lakedaemon.net,
thomas.petazzoni@free-electrons.com
Subject: [tip:smp/hotplug] irqchip/armada: Avoid unused function warnings
Date: Tue, 19 Jul 2016 00:45:55 -0700 [thread overview]
Message-ID: <tip-c76c15e6f16c1529b524ba2c519c4fcef7a45e16@git.kernel.org> (raw)
In-Reply-To: <20160718160335.3134412-1-arnd@arndb.de>
Commit-ID: c76c15e6f16c1529b524ba2c519c4fcef7a45e16
Gitweb: http://git.kernel.org/tip/c76c15e6f16c1529b524ba2c519c4fcef7a45e16
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Mon, 18 Jul 2016 18:03:21 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 19 Jul 2016 09:43:43 +0200
irqchip/armada: Avoid unused function warnings
When building with CONFIG_SMP disabled, we get some new harmless warnings:
drivers/irqchip/irq-armada-370-xp.c:356:12: error: 'mpic_cascaded_starting_cpu' defined but not used [-Werror=unused-function]
static int mpic_cascaded_starting_cpu(unsigned int cpu)
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/irqchip/irq-armada-370-xp.c:349:12: error: 'armada_xp_mpic_starting_cpu' defined but not used [-Werror=unused-function]
static int armada_xp_mpic_starting_cpu(unsigned int cpu)
This moves the unused functions into the #ifdef, as they previously were.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jason Cooper <jason@lakedaemon.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Richard Cochran <rcochran@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Fixes: cb5ff2d245c1 ("irqchip/armada-370-xp: Convert to hotplug state machine")
Link: http://lkml.kernel.org/r/20160718160335.3134412-1-arnd@arndb.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/irqchip/irq-armada-370-xp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
index e2b8fee..cdef440 100644
--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -344,7 +344,6 @@ static void armada_mpic_send_doorbell(const struct cpumask *mask,
writel((map << 8) | irq, main_int_base +
ARMADA_370_XP_SW_TRIG_INT_OFFS);
}
-#endif
static int armada_xp_mpic_starting_cpu(unsigned int cpu)
{
@@ -359,6 +358,7 @@ static int mpic_cascaded_starting_cpu(unsigned int cpu)
enable_percpu_irq(parent_irq, IRQ_TYPE_NONE);
return 0;
}
+#endif
static const struct irq_domain_ops armada_370_xp_mpic_irq_ops = {
.map = armada_370_xp_mpic_irq_map,
prev parent reply other threads:[~2016-07-19 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 16:03 [PATCH] irqchip: armada: avoid unused function warnings Arnd Bergmann
2016-07-18 19:22 ` Jason Cooper
2016-07-19 7:45 ` tip-bot for Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c76c15e6f16c1529b524ba2c519c4fcef7a45e16@git.kernel.org \
--to=tipbot@zytor.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rcochran@linutronix.de \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).