From: tip-bot for Masami Hiramatsu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
jkosina@suse.cz, jbaron@akamai.com,
masami.hiramatsu.pt@hitachi.com, bpetkov@suse.de,
rostedt@goodmis.org, tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:perf/core] kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
Date: Sun, 21 Jul 2013 06:43:31 -0700 [thread overview]
Message-ID: <tip-c7e85c42be68fca743df58a306edd29aa295e155@git.kernel.org> (raw)
In-Reply-To: <20130718114747.26675.84110.stgit@mhiramat-M0-7522>
Commit-ID: c7e85c42be68fca743df58a306edd29aa295e155
Gitweb: http://git.kernel.org/tip/c7e85c42be68fca743df58a306edd29aa295e155
Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
AuthorDate: Thu, 18 Jul 2013 20:47:47 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 19 Jul 2013 09:57:03 +0200
kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE
Remove a comment about an int3 issue in NMI/MCE, since
commit:
3f3c8b8c4b2a ("x86: Add workaround to NMI iret woes")
already fixed that. Keeping this incorrect comment can mislead developers.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Jason Baron <jbaron@akamai.com>
Cc: yrl.pp-manager.tt@hitachi.com
Cc: Borislav Petkov <bpetkov@suse.de>
Link: http://lkml.kernel.org/r/20130718114747.26675.84110.stgit@mhiramat-M0-7522
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/kprobes/opt.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/arch/x86/kernel/kprobes/opt.c b/arch/x86/kernel/kprobes/opt.c
index 76dc6f0..d7d8a8c 100644
--- a/arch/x86/kernel/kprobes/opt.c
+++ b/arch/x86/kernel/kprobes/opt.c
@@ -415,11 +415,6 @@ void __kprobes arch_optimize_kprobes(struct list_head *oplist)
break;
}
- /*
- * text_poke_smp doesn't support NMI/MCE code modifying.
- * However, since kprobes itself also doesn't support NMI/MCE
- * code probing, it's not a problem.
- */
text_poke_smp_batch(jump_poke_params, c);
}
@@ -455,11 +450,6 @@ extern void arch_unoptimize_kprobes(struct list_head *oplist,
break;
}
- /*
- * text_poke_smp doesn't support NMI/MCE code modifying.
- * However, since kprobes itself also doesn't support NMI/MCE
- * code probing, it's not a problem.
- */
text_poke_smp_batch(jump_poke_params, c);
}
next prev parent reply other threads:[~2013-07-21 13:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 11:47 [PATCH -tip 0/3] kprobes, x86: Move optprobe on top of int3-based instruction patching Masami Hiramatsu
2013-07-18 11:47 ` [PATCH -tip 1/3] [CLEANUP] kprobes/x86: Remove an incorrect comment about int3 in NMI/MCE Masami Hiramatsu
2013-07-21 13:43 ` tip-bot for Masami Hiramatsu [this message]
2013-07-18 11:47 ` [PATCH -tip 2/3] kprobes/x86: Use text_poke_bp() instead of text_poke_smp*() Masami Hiramatsu
2013-07-21 13:43 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2013-07-18 11:47 ` [PATCH -tip 3/3] x86: Remove unused text_poke_smp and text_poke_smp_batch Masami Hiramatsu
2013-07-21 13:43 ` [tip:perf/core] kprobes/x86: Remove unused text_poke_smp() and text_poke_smp_batch() functions tip-bot for Masami Hiramatsu
2013-07-22 7:18 ` [tip:x86/jumplabel] " tip-bot for Masami Hiramatsu
2013-07-22 7:43 ` [PATCH -tip 3/3] x86: Remove unused text_poke_smp and text_poke_smp_batch Ingo Molnar
2013-07-22 8:04 ` Masami Hiramatsu
2013-07-22 8:21 ` Ingo Molnar
2013-07-22 8:38 ` Masami Hiramatsu
2013-07-22 10:01 ` Ingo Molnar
2013-07-22 10:11 ` Masami Hiramatsu
2013-07-22 10:21 ` Ingo Molnar
2013-07-22 13:53 ` Jiri Kosina
2013-07-23 8:10 ` Ingo Molnar
2013-07-18 22:24 ` [PATCH -tip 0/3] kprobes, x86: Move optprobe on top of int3-based instruction patching Jiri Kosina
2013-07-20 1:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-c7e85c42be68fca743df58a306edd29aa295e155@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bpetkov@suse.de \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).