From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970225AbdDTL0D (ORCPT ); Thu, 20 Apr 2017 07:26:03 -0400 Received: from terminus.zytor.com ([65.50.211.136]:53533 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S970209AbdDTL0B (ORCPT ); Thu, 20 Apr 2017 07:26:01 -0400 Date: Thu, 20 Apr 2017 04:22:25 -0700 From: tip-bot for Sebastian Andrzej Siewior Message-ID: Cc: mathieu.poirier@linaro.org, tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, peterz@infradead.org, linux-kernel@vger.kernel.org, hpa@zytor.com Reply-To: mathieu.poirier@linaro.org, bigeasy@linutronix.de, mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, rostedt@goodmis.org, hpa@zytor.com In-Reply-To: <20170418170553.026838125@linutronix.de> References: <20170418170553.026838125@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] hwtracing/coresight-etm3x: Use cpuhp_setup_state_nocalls_cpuslocked() Git-Commit-ID: c8fbca5abedcbf4212a34b7d3aef9c2adc44d36e X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: c8fbca5abedcbf4212a34b7d3aef9c2adc44d36e Gitweb: http://git.kernel.org/tip/c8fbca5abedcbf4212a34b7d3aef9c2adc44d36e Author: Sebastian Andrzej Siewior AuthorDate: Tue, 18 Apr 2017 19:04:50 +0200 Committer: Thomas Gleixner CommitDate: Thu, 20 Apr 2017 13:08:52 +0200 hwtracing/coresight-etm3x: Use cpuhp_setup_state_nocalls_cpuslocked() etm_probe() holds get_online_cpus() while invoking cpuhp_setup_state_nocalls(). cpuhp_setup_state_nocalls() invokes get_online_cpus() as well. This is correct, but prevents the conversion of the hotplug locking to a percpu rwsem. Use cpuhp_setup_state_nocalls_cpuslocked() to avoid the nested call. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Mathieu Poirier Cc: Peter Zijlstra Cc: Steven Rostedt Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20170418170553.026838125@linutronix.de --- drivers/hwtracing/coresight/coresight-etm3x.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c index a51b6b6..c9a0a75 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x.c +++ b/drivers/hwtracing/coresight/coresight-etm3x.c @@ -803,12 +803,12 @@ static int etm_probe(struct amba_device *adev, const struct amba_id *id) dev_err(dev, "ETM arch init failed\n"); if (!etm_count++) { - cpuhp_setup_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING, - "arm/coresight:starting", - etm_starting_cpu, etm_dying_cpu); - ret = cpuhp_setup_state_nocalls(CPUHP_AP_ONLINE_DYN, - "arm/coresight:online", - etm_online_cpu, NULL); + cpuhp_setup_state_nocalls_cpuslocked(CPUHP_AP_ARM_CORESIGHT_STARTING, + "arm/coresight:starting", + etm_starting_cpu, etm_dying_cpu); + ret = cpuhp_setup_state_nocalls_cpuslocked(CPUHP_AP_ONLINE_DYN, + "arm/coresight:online", + etm_online_cpu, NULL); if (ret < 0) goto err_arch_supported; hp_online = ret;