From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754390AbcA3IZi (ORCPT ); Sat, 30 Jan 2016 03:25:38 -0500 Received: from terminus.zytor.com ([198.137.202.10]:36685 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbcA3IZf (ORCPT ); Sat, 30 Jan 2016 03:25:35 -0500 Date: Sat, 30 Jan 2016 00:24:57 -0800 From: tip-bot for Markus Trippelsdorf Message-ID: Cc: acme@redhat.com, matt@codeblueprint.co.uk, markus@trippelsdorf.de, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, ben@decadent.org.uk, tglx@linutronix.de, hpa@zytor.com Reply-To: acme@redhat.com, matt@codeblueprint.co.uk, peterz@infradead.org, linux-kernel@vger.kernel.org, markus@trippelsdorf.de, hpa@zytor.com, tglx@linutronix.de, ben@decadent.org.uk, mingo@kernel.org In-Reply-To: <20151214154403.GB1409@x4> References: <20151214154403.GB1409@x4> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed Git-Commit-ID: d4913cbd05bab685e49c8174896e563b2487d054 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: d4913cbd05bab685e49c8174896e563b2487d054 Gitweb: http://git.kernel.org/tip/d4913cbd05bab685e49c8174896e563b2487d054 Author: Markus Trippelsdorf AuthorDate: Mon, 14 Dec 2015 16:44:03 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 26 Jan 2016 11:14:25 -0300 perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed The issue was pointed out by gcc-6's -Wmisleading-indentation. Signed-off-by: Markus Trippelsdorf Acked-by: Ingo Molnar Cc: Ben Hutchings Cc: Matt Fleming Cc: Peter Zijlstra Fixes: c97cf42219b7 ("perf top: Live TUI Annotation") Link: http://lkml.kernel.org/r/20151214154403.GB1409@x4 Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index d4d7cc2..718bd46 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -755,11 +755,11 @@ static int annotate_browser__run(struct annotate_browser *browser, nd = browser->curr_hot; break; case K_UNTAB: - if (nd != NULL) + if (nd != NULL) { nd = rb_next(nd); if (nd == NULL) nd = rb_first(&browser->entries); - else + } else nd = browser->curr_hot; break; case K_F1: