* [PATCH v1] genirq: Add wakeup sysfs node to show IRQ wakeup state
@ 2018-02-26 15:50 Andy Shevchenko
2018-02-26 21:55 ` Tony Lindgren
2018-02-28 17:10 ` [tip:irq/core] " tip-bot for Andy Shevchenko
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-02-26 15:50 UTC (permalink / raw)
To: Thomas Gleixner, linux-kernel, Tony Lindgren, Grygorii Strashko,
Rafael J . Wysocki
Cc: Andy Shevchenko
Surprisingly there is no simple way to see if the IRQ line in question
is wakeup source or not.
Note that wakeup might be an OOB (out-of-band) source like GPIO line
which makes things slightly more complicated.
Add a sysfs node to cover this case.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Documentation/ABI/testing/sysfs-kernel-irq | 7 +++++++
kernel/irq/irqdesc.c | 17 +++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-kernel-irq b/Documentation/ABI/testing/sysfs-kernel-irq
index eb074b100986..8910d0c4bcd8 100644
--- a/Documentation/ABI/testing/sysfs-kernel-irq
+++ b/Documentation/ABI/testing/sysfs-kernel-irq
@@ -51,3 +51,10 @@ Date: September 2016
KernelVersion: 4.9
Contact: Craig Gallek <kraig@google.com>
Description: The type of the interrupt. Either the string 'level' or 'edge'.
+
+What: /sys/kernel/irq/<irq>/wakeup
+Date: March 2018
+KernelVersion: 4.17
+Contact: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
+Description: The wakeup state of the interrupt. Either the string
+ 'enabled' or 'disabled'.
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 49b54e9979cc..d9ded088d336 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -210,6 +210,22 @@ static ssize_t type_show(struct kobject *kobj,
}
IRQ_ATTR_RO(type);
+static ssize_t wakeup_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
+ ssize_t ret = 0;
+
+ raw_spin_lock_irq(&desc->lock);
+ ret = sprintf(buf, "%s\n",
+ irqd_is_wakeup_set(&desc->irq_data) ? "enabled" : "disabled");
+ raw_spin_unlock_irq(&desc->lock);
+
+ return ret;
+
+}
+IRQ_ATTR_RO(wakeup);
+
static ssize_t name_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
@@ -253,6 +269,7 @@ static struct attribute *irq_attrs[] = {
&chip_name_attr.attr,
&hwirq_attr.attr,
&type_attr.attr,
+ &wakeup_attr.attr,
&name_attr.attr,
&actions_attr.attr,
NULL
--
2.16.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] genirq: Add wakeup sysfs node to show IRQ wakeup state
2018-02-26 15:50 [PATCH v1] genirq: Add wakeup sysfs node to show IRQ wakeup state Andy Shevchenko
@ 2018-02-26 21:55 ` Tony Lindgren
2018-02-28 17:10 ` [tip:irq/core] " tip-bot for Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-02-26 21:55 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Thomas Gleixner, linux-kernel, Grygorii Strashko, Rafael J . Wysocki
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [180226 15:51]:
> Surprisingly there is no simple way to see if the IRQ line in question
> is wakeup source or not.
>
> Note that wakeup might be an OOB (out-of-band) source like GPIO line
> which makes things slightly more complicated.
>
> Add a sysfs node to cover this case.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Works for me:
Tested-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:irq/core] genirq: Add wakeup sysfs node to show IRQ wakeup state
2018-02-26 15:50 [PATCH v1] genirq: Add wakeup sysfs node to show IRQ wakeup state Andy Shevchenko
2018-02-26 21:55 ` Tony Lindgren
@ 2018-02-28 17:10 ` tip-bot for Andy Shevchenko
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Andy Shevchenko @ 2018-02-28 17:10 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, mingo, tglx, grygorii.strashko, rafael.j.wysocki,
andriy.shevchenko, hpa, tony
Commit-ID: d61e2944b6364006e3d7a0152aaafda741c8c876
Gitweb: https://git.kernel.org/tip/d61e2944b6364006e3d7a0152aaafda741c8c876
Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Mon, 26 Feb 2018 17:50:43 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 28 Feb 2018 18:07:20 +0100
genirq: Add wakeup sysfs node to show IRQ wakeup state
Surprisingly there is no simple way to see if the IRQ line in question
is wakeup source or not.
Note that wakeup might be an OOB (out-of-band) source like GPIO line
which makes things slightly more complicated.
Add a sysfs node to cover this case.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Tony Lindgren <tony@atomide.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Link: https://lkml.kernel.org/r/20180226155043.67937-1-andriy.shevchenko@linux.intel.com
---
Documentation/ABI/testing/sysfs-kernel-irq | 7 +++++++
kernel/irq/irqdesc.c | 17 +++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-kernel-irq b/Documentation/ABI/testing/sysfs-kernel-irq
index eb074b100986..8910d0c4bcd8 100644
--- a/Documentation/ABI/testing/sysfs-kernel-irq
+++ b/Documentation/ABI/testing/sysfs-kernel-irq
@@ -51,3 +51,10 @@ Date: September 2016
KernelVersion: 4.9
Contact: Craig Gallek <kraig@google.com>
Description: The type of the interrupt. Either the string 'level' or 'edge'.
+
+What: /sys/kernel/irq/<irq>/wakeup
+Date: March 2018
+KernelVersion: 4.17
+Contact: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
+Description: The wakeup state of the interrupt. Either the string
+ 'enabled' or 'disabled'.
diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 49b54e9979cc..d9ded088d336 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -210,6 +210,22 @@ static ssize_t type_show(struct kobject *kobj,
}
IRQ_ATTR_RO(type);
+static ssize_t wakeup_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
+ ssize_t ret = 0;
+
+ raw_spin_lock_irq(&desc->lock);
+ ret = sprintf(buf, "%s\n",
+ irqd_is_wakeup_set(&desc->irq_data) ? "enabled" : "disabled");
+ raw_spin_unlock_irq(&desc->lock);
+
+ return ret;
+
+}
+IRQ_ATTR_RO(wakeup);
+
static ssize_t name_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
@@ -253,6 +269,7 @@ static struct attribute *irq_attrs[] = {
&chip_name_attr.attr,
&hwirq_attr.attr,
&type_attr.attr,
+ &wakeup_attr.attr,
&name_attr.attr,
&actions_attr.attr,
NULL
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-28 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 15:50 [PATCH v1] genirq: Add wakeup sysfs node to show IRQ wakeup state Andy Shevchenko
2018-02-26 21:55 ` Tony Lindgren
2018-02-28 17:10 ` [tip:irq/core] " tip-bot for Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).