* [PATCH] x86, calgary: constify cal_chipset_ops structures
@ 2015-11-28 15:58 Julia Lawall
2015-11-29 7:58 ` [tip:x86/platform] x86/platform/calgary: Constify " tip-bot for Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-11-28 15:58 UTC (permalink / raw)
To: Muli Ben-Yehuda
Cc: kernel-janitors, Jon D. Mason, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, discuss, linux-kernel
The cal_chipset_ops structures are never modified, so declare them
as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/x86/include/asm/calgary.h | 2 +-
arch/x86/kernel/pci-calgary_64.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/calgary.h b/arch/x86/include/asm/calgary.h
index 0d467b3..a8303eb 100644
--- a/arch/x86/include/asm/calgary.h
+++ b/arch/x86/include/asm/calgary.h
@@ -31,7 +31,7 @@
#include <asm/types.h>
struct iommu_table {
- struct cal_chipset_ops *chip_ops; /* chipset specific funcs */
+ const struct cal_chipset_ops *chip_ops; /* chipset specific funcs */
unsigned long it_base; /* mapped address of tce table */
unsigned long it_hint; /* Hint for next alloc */
unsigned long *it_map; /* A simple allocation bitmap for now */
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index 0497f71..833b1d3 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -180,13 +180,13 @@ static void calioc2_dump_error_regs(struct iommu_table *tbl);
static void calgary_init_bitmap_from_tce_table(struct iommu_table *tbl);
static void get_tce_space_from_tar(void);
-static struct cal_chipset_ops calgary_chip_ops = {
+static const struct cal_chipset_ops calgary_chip_ops = {
.handle_quirks = calgary_handle_quirks,
.tce_cache_blast = calgary_tce_cache_blast,
.dump_error_regs = calgary_dump_error_regs
};
-static struct cal_chipset_ops calioc2_chip_ops = {
+static const struct cal_chipset_ops calioc2_chip_ops = {
.handle_quirks = calioc2_handle_quirks,
.tce_cache_blast = calioc2_tce_cache_blast,
.dump_error_regs = calioc2_dump_error_regs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/platform] x86/platform/calgary: Constify cal_chipset_ops structures
2015-11-28 15:58 [PATCH] x86, calgary: constify cal_chipset_ops structures Julia Lawall
@ 2015-11-29 7:58 ` tip-bot for Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Julia Lawall @ 2015-11-29 7:58 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, jdmason, muli, peterz, Julia.Lawall, torvalds, hpa,
bp, tglx, mingo
Commit-ID: d6b56b0bc68ba7927b286da86eda1d4d4dbe63f6
Gitweb: http://git.kernel.org/tip/d6b56b0bc68ba7927b286da86eda1d4d4dbe63f6
Author: Julia Lawall <Julia.Lawall@lip6.fr>
AuthorDate: Sat, 28 Nov 2015 16:58:15 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Sun, 29 Nov 2015 08:50:58 +0100
x86/platform/calgary: Constify cal_chipset_ops structures
The cal_chipset_ops structures are never modified, so declare
them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jon D. Mason <jdmason@kudzu.us>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1448726295-10959-1-git-send-email-Julia.Lawall@lip6.fr
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/asm/calgary.h | 2 +-
arch/x86/kernel/pci-calgary_64.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/calgary.h b/arch/x86/include/asm/calgary.h
index 0d467b3..a8303eb 100644
--- a/arch/x86/include/asm/calgary.h
+++ b/arch/x86/include/asm/calgary.h
@@ -31,7 +31,7 @@
#include <asm/types.h>
struct iommu_table {
- struct cal_chipset_ops *chip_ops; /* chipset specific funcs */
+ const struct cal_chipset_ops *chip_ops; /* chipset specific funcs */
unsigned long it_base; /* mapped address of tce table */
unsigned long it_hint; /* Hint for next alloc */
unsigned long *it_map; /* A simple allocation bitmap for now */
diff --git a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
index 0497f71..833b1d3 100644
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -180,13 +180,13 @@ static void calioc2_dump_error_regs(struct iommu_table *tbl);
static void calgary_init_bitmap_from_tce_table(struct iommu_table *tbl);
static void get_tce_space_from_tar(void);
-static struct cal_chipset_ops calgary_chip_ops = {
+static const struct cal_chipset_ops calgary_chip_ops = {
.handle_quirks = calgary_handle_quirks,
.tce_cache_blast = calgary_tce_cache_blast,
.dump_error_regs = calgary_dump_error_regs
};
-static struct cal_chipset_ops calioc2_chip_ops = {
+static const struct cal_chipset_ops calioc2_chip_ops = {
.handle_quirks = calioc2_handle_quirks,
.tce_cache_blast = calioc2_tce_cache_blast,
.dump_error_regs = calioc2_dump_error_regs
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-29 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-28 15:58 [PATCH] x86, calgary: constify cal_chipset_ops structures Julia Lawall
2015-11-29 7:58 ` [tip:x86/platform] x86/platform/calgary: Constify " tip-bot for Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).