From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1957033AbdDZIeP (ORCPT ); Wed, 26 Apr 2017 04:34:15 -0400 Received: from terminus.zytor.com ([65.50.211.136]:48579 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1955582AbdDZIeB (ORCPT ); Wed, 26 Apr 2017 04:34:01 -0400 Date: Wed, 26 Apr 2017 01:28:04 -0700 From: tip-bot for Andy Lutomirski Message-ID: Cc: hpa@zytor.com, torvalds@linux-foundation.org, konrad.wilk@oracle.com, riel@redhat.com, tglx@linutronix.de, luto@kernel.org, brgerst@gmail.com, jpoimboe@redhat.com, peterz@infradead.org, namit@vmware.com, mingo@kernel.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, dave.hansen@intel.com, jgross@suse.com, dvlasenk@redhat.com, akpm@linux-foundation.org, bp@alien8.de, mhocko@suse.com Reply-To: brgerst@gmail.com, jpoimboe@redhat.com, riel@redhat.com, luto@kernel.org, tglx@linutronix.de, konrad.wilk@oracle.com, hpa@zytor.com, torvalds@linux-foundation.org, bp@alien8.de, akpm@linux-foundation.org, mhocko@suse.com, dave.hansen@intel.com, dvlasenk@redhat.com, jgross@suse.com, mingo@kernel.org, namit@vmware.com, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, peterz@infradead.org In-Reply-To: <10ed0e4dfea64daef10b87fb85df1746999b4dba.1492844372.git.luto@kernel.org> References: <10ed0e4dfea64daef10b87fb85df1746999b4dba.1492844372.git.luto@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/mm: Fix flush_tlb_page() on Xen Git-Commit-ID: dbd68d8e84c606673ebbcf15862f8c155fa92326 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: dbd68d8e84c606673ebbcf15862f8c155fa92326 Gitweb: http://git.kernel.org/tip/dbd68d8e84c606673ebbcf15862f8c155fa92326 Author: Andy Lutomirski AuthorDate: Sat, 22 Apr 2017 00:01:22 -0700 Committer: Ingo Molnar CommitDate: Wed, 26 Apr 2017 10:02:06 +0200 x86/mm: Fix flush_tlb_page() on Xen flush_tlb_page() passes a bogus range to flush_tlb_others() and expects the latter to fix it up. native_flush_tlb_others() has the fixup but Xen's version doesn't. Move the fixup to flush_tlb_others(). AFAICS the only real effect is that, without this fix, Xen would flush everything instead of just the one page on remote vCPUs in when flush_tlb_page() was called. Signed-off-by: Andy Lutomirski Reviewed-by: Boris Ostrovsky Cc: Andrew Morton Cc: Borislav Petkov Cc: Brian Gerst Cc: Dave Hansen Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Juergen Gross Cc: Konrad Rzeszutek Wilk Cc: Linus Torvalds Cc: Michal Hocko Cc: Nadav Amit Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Fixes: e7b52ffd45a6 ("x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range") Link: http://lkml.kernel.org/r/10ed0e4dfea64daef10b87fb85df1746999b4dba.1492844372.git.luto@kernel.org Signed-off-by: Ingo Molnar --- arch/x86/mm/tlb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 9db9260..6e7bedf 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -263,8 +263,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask, { struct flush_tlb_info info; - if (end == 0) - end = start + PAGE_SIZE; info.flush_mm = mm; info.flush_start = start; info.flush_end = end; @@ -378,7 +376,7 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long start) } if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) - flush_tlb_others(mm_cpumask(mm), mm, start, 0UL); + flush_tlb_others(mm_cpumask(mm), mm, start, start + PAGE_SIZE); preempt_enable(); }