* [PATCH] x86/topology: Document cpu_llc_id
@ 2016-09-07 9:22 Borislav Petkov
2016-09-07 10:36 ` Peter Zijlstra
0 siblings, 1 reply; 8+ messages in thread
From: Borislav Petkov @ 2016-09-07 9:22 UTC (permalink / raw)
To: X86 ML; +Cc: LKML, Peter Zijlstra, Thomas Gleixner
From: Borislav Petkov <bp@suse.de>
It means different things on Intel and AMD so write it down so that
there's no confusion.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
Documentation/x86/topology.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
index 06afac252f5b..7a5485730476 100644
--- a/Documentation/x86/topology.txt
+++ b/Documentation/x86/topology.txt
@@ -63,6 +63,12 @@ The topology of a system is described in the units of:
The maximum possible number of packages in the system. Helpful for per
package facilities to preallocate per package information.
+ - cpu_llc_id:
+
+ A per-CPU variable containing:
+ - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
+ Cache
+ - On AMD, the Node ID containing the Last Level Cache.
* Cores:
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] x86/topology: Document cpu_llc_id
2016-09-07 9:22 [PATCH] x86/topology: Document cpu_llc_id Borislav Petkov
@ 2016-09-07 10:36 ` Peter Zijlstra
2016-11-14 6:29 ` Borislav Petkov
0 siblings, 1 reply; 8+ messages in thread
From: Peter Zijlstra @ 2016-09-07 10:36 UTC (permalink / raw)
To: Borislav Petkov; +Cc: X86 ML, LKML, Thomas Gleixner
On Wed, Sep 07, 2016 at 11:22:19AM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> It means different things on Intel and AMD so write it down so that
> there's no confusion.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> ---
> Documentation/x86/topology.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
> index 06afac252f5b..7a5485730476 100644
> --- a/Documentation/x86/topology.txt
> +++ b/Documentation/x86/topology.txt
> @@ -63,6 +63,12 @@ The topology of a system is described in the units of:
> The maximum possible number of packages in the system. Helpful for per
> package facilities to preallocate per package information.
>
> + - cpu_llc_id:
> +
> + A per-CPU variable containing:
> + - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
> + Cache
> + - On AMD, the Node ID containing the Last Level Cache.
And there are no AMD parts where there are multiple LLCs on a Node? Like
where there isn't an L3 and the L2 is only per cluster?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] x86/topology: Document cpu_llc_id
2016-09-07 10:36 ` Peter Zijlstra
@ 2016-11-14 6:29 ` Borislav Petkov
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
0 siblings, 1 reply; 8+ messages in thread
From: Borislav Petkov @ 2016-11-14 6:29 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: X86 ML, LKML, Thomas Gleixner, Yazen Ghannam
On Wed, Sep 07, 2016 at 12:36:41PM +0200, Peter Zijlstra wrote:
> On Wed, Sep 07, 2016 at 11:22:19AM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > It means different things on Intel and AMD so write it down so that
> > there's no confusion.
> >
> > Signed-off-by: Borislav Petkov <bp@suse.de>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > Documentation/x86/topology.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
> > index 06afac252f5b..7a5485730476 100644
> > --- a/Documentation/x86/topology.txt
> > +++ b/Documentation/x86/topology.txt
> > @@ -63,6 +63,12 @@ The topology of a system is described in the units of:
> > The maximum possible number of packages in the system. Helpful for per
> > package facilities to preallocate per package information.
> >
> > + - cpu_llc_id:
> > +
> > + A per-CPU variable containing:
> > + - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
> > + Cache
> > + - On AMD, the Node ID containing the Last Level Cache.
>
> And there are no AMD parts where there are multiple LLCs on a Node? Like
> where there isn't an L3 and the L2 is only per cluster?
Yes there are (now), see:
http://git.kernel.org/tip/b0b6e86846093c5f8820386bc01515f857dd8faa
But those LLC ID numbers are still increasing IDs of either nodes or
core complexes in Zen's case. So I think the text should say:
"- On AMD, the Node ID or Core Complex ID containing the Last Level Cache. In
general, numbers identifying an LLC uniquely on the system."
How's that?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH -v1.1] x86/topology: Document cpu_llc_id
2016-11-14 6:29 ` Borislav Petkov
@ 2016-11-17 9:45 ` Borislav Petkov
2016-11-17 12:57 ` Yazen Ghannam
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Borislav Petkov @ 2016-11-17 9:45 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: X86 ML, LKML, Thomas Gleixner, Yazen Ghannam
It means different things on Intel and AMD so write it down so that
there's no confusion.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
---
Documentation/x86/topology.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
index 06afac252f5b..f3e9d7e9ed6c 100644
--- a/Documentation/x86/topology.txt
+++ b/Documentation/x86/topology.txt
@@ -63,6 +63,15 @@ The topology of a system is described in the units of:
The maximum possible number of packages in the system. Helpful for per
package facilities to preallocate per package information.
+ - cpu_llc_id:
+
+ A per-CPU variable containing:
+ - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
+ Cache
+
+ - On AMD, the Node ID or Core Complex ID containing the Last Level
+ Cache. In general, it is a number identifying an LLC uniquely on the
+ system.
* Cores:
--
2.10.0
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH -v1.1] x86/topology: Document cpu_llc_id
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
@ 2016-11-17 12:57 ` Yazen Ghannam
2016-11-17 14:16 ` Borislav Petkov
2016-12-19 11:34 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2016-12-20 9:34 ` tip-bot for Borislav Petkov
2 siblings, 1 reply; 8+ messages in thread
From: Yazen Ghannam @ 2016-11-17 12:57 UTC (permalink / raw)
To: Borislav Petkov; +Cc: Peter Zijlstra, X86 ML, LKML, Thomas Gleixner
On Thu, Nov 17, 2016 at 10:45:57AM +0100, Borislav Petkov wrote:
> It means different things on Intel and AMD so write it down so that
> there's no confusion.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> Documentation/x86/topology.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
> index 06afac252f5b..f3e9d7e9ed6c 100644
> --- a/Documentation/x86/topology.txt
> +++ b/Documentation/x86/topology.txt
> @@ -63,6 +63,15 @@ The topology of a system is described in the units of:
> The maximum possible number of packages in the system. Helpful for per
> package facilities to preallocate per package information.
>
> + - cpu_llc_id:
> +
> + A per-CPU variable containing:
> + - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
> + Cache
> +
> + - On AMD, the Node ID or Core Complex ID containing the Last Level
> + Cache. In general, it is a number identifying an LLC uniquely on the
> + system.
>
> * Cores:
>
Look good to me.
Thanks,
Yazen
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -v1.1] x86/topology: Document cpu_llc_id
2016-11-17 12:57 ` Yazen Ghannam
@ 2016-11-17 14:16 ` Borislav Petkov
0 siblings, 0 replies; 8+ messages in thread
From: Borislav Petkov @ 2016-11-17 14:16 UTC (permalink / raw)
To: Yazen Ghannam; +Cc: Peter Zijlstra, X86 ML, LKML, Thomas Gleixner
On Thu, Nov 17, 2016 at 07:57:11AM -0500, Yazen Ghannam wrote:
> Look good to me.
We normally say that with:
Acked-by: "name" <email@address>
:-)
Thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [tip:x86/urgent] x86/topology: Document cpu_llc_id
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
2016-11-17 12:57 ` Yazen Ghannam
@ 2016-12-19 11:34 ` tip-bot for Borislav Petkov
2016-12-20 9:34 ` tip-bot for Borislav Petkov
2 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Borislav Petkov @ 2016-12-19 11:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, tglx, mingo, yazen.ghannam, bp, hpa, peterz, bp
Commit-ID: dbf12ae564c022a741a6983b2bb4aeea5b8c0efd
Gitweb: http://git.kernel.org/tip/dbf12ae564c022a741a6983b2bb4aeea5b8c0efd
Author: Borislav Petkov <bp@alien8.de>
AuthorDate: Thu, 17 Nov 2016 10:45:57 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 19 Dec 2016 12:27:53 +0100
x86/topology: Document cpu_llc_id
It means different things on Intel and AMD so write it down so that
there's no confusion.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Link: http://lkml.kernel.org/r/20161117094557.jm6hwzdd52h7iwnj@pd.tnic
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
Documentation/x86/topology.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
index 06afac2..f3e9d7e 100644
--- a/Documentation/x86/topology.txt
+++ b/Documentation/x86/topology.txt
@@ -63,6 +63,15 @@ The topology of a system is described in the units of:
The maximum possible number of packages in the system. Helpful for per
package facilities to preallocate per package information.
+ - cpu_llc_id:
+
+ A per-CPU variable containing:
+ - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
+ Cache
+
+ - On AMD, the Node ID or Core Complex ID containing the Last Level
+ Cache. In general, it is a number identifying an LLC uniquely on the
+ system.
* Cores:
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [tip:x86/urgent] x86/topology: Document cpu_llc_id
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
2016-11-17 12:57 ` Yazen Ghannam
2016-12-19 11:34 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
@ 2016-12-20 9:34 ` tip-bot for Borislav Petkov
2 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Borislav Petkov @ 2016-12-20 9:34 UTC (permalink / raw)
To: linux-tip-commits
Cc: bp, linux-kernel, yazen.ghannam, peterz, hpa, bp, tglx, mingo
Commit-ID: a268b5f1d6e4639fa6d78fc8bdddaebaa032ab24
Gitweb: http://git.kernel.org/tip/a268b5f1d6e4639fa6d78fc8bdddaebaa032ab24
Author: Borislav Petkov <bp@alien8.de>
AuthorDate: Thu, 17 Nov 2016 10:45:57 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 20 Dec 2016 09:36:29 +0100
x86/topology: Document cpu_llc_id
It means different things on Intel and AMD so write it down so that
there's no confusion.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Link: http://lkml.kernel.org/r/20161117094557.jm6hwzdd52h7iwnj@pd.tnic
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
Documentation/x86/topology.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/x86/topology.txt b/Documentation/x86/topology.txt
index 06afac2..f3e9d7e 100644
--- a/Documentation/x86/topology.txt
+++ b/Documentation/x86/topology.txt
@@ -63,6 +63,15 @@ The topology of a system is described in the units of:
The maximum possible number of packages in the system. Helpful for per
package facilities to preallocate per package information.
+ - cpu_llc_id:
+
+ A per-CPU variable containing:
+ - On Intel, the first APIC ID of the list of CPUs sharing the Last Level
+ Cache
+
+ - On AMD, the Node ID or Core Complex ID containing the Last Level
+ Cache. In general, it is a number identifying an LLC uniquely on the
+ system.
* Cores:
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-20 9:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 9:22 [PATCH] x86/topology: Document cpu_llc_id Borislav Petkov
2016-09-07 10:36 ` Peter Zijlstra
2016-11-14 6:29 ` Borislav Petkov
2016-11-17 9:45 ` [PATCH -v1.1] " Borislav Petkov
2016-11-17 12:57 ` Yazen Ghannam
2016-11-17 14:16 ` Borislav Petkov
2016-12-19 11:34 ` [tip:x86/urgent] " tip-bot for Borislav Petkov
2016-12-20 9:34 ` tip-bot for Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).