From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754668AbcKIW4l (ORCPT ); Wed, 9 Nov 2016 17:56:41 -0500 Received: from terminus.zytor.com ([198.137.202.10]:55470 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754480AbcKIW4j (ORCPT ); Wed, 9 Nov 2016 17:56:39 -0500 Date: Wed, 9 Nov 2016 14:56:32 -0800 From: tip-bot for Thomas Gleixner Message-ID: Cc: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, bigeasy@linutronix.de, mingo@kernel.org Reply-To: schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, hpa@zytor.com, mingo@kernel.org, bigeasy@linutronix.de In-Reply-To: <20161104144140.lcee6kwmwlx37m7g@linutronix.de> References: <20161104144140.lcee6kwmwlx37m7g@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] s390/smp: Make cpu notifier symetric Git-Commit-ID: ef65d45cbfbb438a5fbe8ef3fc424314ff1e8b7c X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: ef65d45cbfbb438a5fbe8ef3fc424314ff1e8b7c Gitweb: http://git.kernel.org/tip/ef65d45cbfbb438a5fbe8ef3fc424314ff1e8b7c Author: Thomas Gleixner AuthorDate: Fri, 4 Nov 2016 15:41:41 +0100 Committer: Thomas Gleixner CommitDate: Wed, 9 Nov 2016 23:45:28 +0100 s390/smp: Make cpu notifier symetric There is no reason to remove the sysfs cpu files when the CPU is dead, they can be removed when the cpu is prepared to go down. Doing it at DOWN_PREPARE allows us to convert it to a symetric hotplug state in the next step. Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior Acked-by: Heiko Carstens Cc: Martin Schwidefsky Cc: linux-s390@vger.kernel.org Cc: rt@linutronix.de Link: http://lkml.kernel.org/r/20161104144140.lcee6kwmwlx37m7g@linutronix.de Signed-off-by: Thomas Gleixner --- arch/s390/kernel/smp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c index 35531fe..2a9c03d 100644 --- a/arch/s390/kernel/smp.c +++ b/arch/s390/kernel/smp.c @@ -1056,9 +1056,10 @@ static int smp_cpu_notify(struct notifier_block *self, unsigned long action, switch (action & ~CPU_TASKS_FROZEN) { case CPU_ONLINE: + case CPU_DOWN_FAILED: err = sysfs_create_group(&s->kobj, &cpu_online_attr_group); break; - case CPU_DEAD: + case CPU_DOWN_PREPARE: sysfs_remove_group(&s->kobj, &cpu_online_attr_group); break; }