From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944958AbdDTL2y (ORCPT ); Thu, 20 Apr 2017 07:28:54 -0400 Received: from terminus.zytor.com ([65.50.211.136]:49769 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943891AbdDTL2i (ORCPT ); Thu, 20 Apr 2017 07:28:38 -0400 Date: Thu, 20 Apr 2017 04:23:57 -0700 From: tip-bot for Sebastian Andrzej Siewior Message-ID: Cc: will.deacon@arm.com, linux@armlinux.org.uk, mark.rutland@arm.com, tglx@linutronix.de, hpa@zytor.com, peterz@infradead.org, linux-kernel@vger.kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, mingo@kernel.org Reply-To: hpa@zytor.com, tglx@linutronix.de, mark.rutland@arm.com, linux@armlinux.org.uk, will.deacon@arm.com, mingo@kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, peterz@infradead.org In-Reply-To: <20170418170553.274229815@linutronix.de> References: <20170418170553.274229815@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:smp/hotplug] ARM/hw_breakpoint: Use cpuhp_setup_state_cpuslocked() Git-Commit-ID: f29f3fd01356bd8ac1f95ab098e9139ae6c945bb X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f29f3fd01356bd8ac1f95ab098e9139ae6c945bb Gitweb: http://git.kernel.org/tip/f29f3fd01356bd8ac1f95ab098e9139ae6c945bb Author: Sebastian Andrzej Siewior AuthorDate: Tue, 18 Apr 2017 19:04:53 +0200 Committer: Thomas Gleixner CommitDate: Thu, 20 Apr 2017 13:08:53 +0200 ARM/hw_breakpoint: Use cpuhp_setup_state_cpuslocked() arch_hw_breakpoint_init() holds get_online_cpus() while registerring the hotplug callbacks. cpuhp_setup_state() invokes get_online_cpus() as well. This is correct, but prevents the conversion of the hotplug locking to a percpu rwsem. Use cpuhp_setup_state_cpuslocked() to avoid the nested call. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Acked-by: Mark Rutland Cc: Peter Zijlstra Cc: Will Deacon Cc: Steven Rostedt Cc: Russell King Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20170418170553.274229815@linutronix.de --- arch/arm/kernel/hw_breakpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c index be3b3fb..2320780 100644 --- a/arch/arm/kernel/hw_breakpoint.c +++ b/arch/arm/kernel/hw_breakpoint.c @@ -1098,8 +1098,9 @@ static int __init arch_hw_breakpoint_init(void) * assume that a halting debugger will leave the world in a nice state * for us. */ - ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "arm/hw_breakpoint:online", - dbg_reset_online, NULL); + ret = cpuhp_setup_state_cpuslocked(CPUHP_AP_ONLINE_DYN, + "arm/hw_breakpoint:online", + dbg_reset_online, NULL); unregister_undef_hook(&debug_reg_hook); if (WARN_ON(ret < 0) || !cpumask_empty(&debug_err_mask)) { core_num_brps = 0;