From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE08C10F13 for ; Sun, 14 Apr 2019 20:37:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52E502082E for ; Sun, 14 Apr 2019 20:37:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfDNUh3 (ORCPT ); Sun, 14 Apr 2019 16:37:29 -0400 Received: from terminus.zytor.com ([198.137.202.136]:60585 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfDNUh2 (ORCPT ); Sun, 14 Apr 2019 16:37:28 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x3EKaruZ2689207 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 14 Apr 2019 13:36:53 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x3EKap602689201; Sun, 14 Apr 2019 13:36:51 -0700 Date: Sun, 14 Apr 2019 13:36:51 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Thomas Gleixner Message-ID: Cc: glider@google.com, jpoimboe@redhat.com, luto@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@kernel.org, peterz@infradead.org, gxt@pku.edu.cn Reply-To: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de, luto@kernel.org, glider@google.com, jpoimboe@redhat.com, peterz@infradead.org, gxt@pku.edu.cn, mingo@kernel.org, rostedt@goodmis.org In-Reply-To: <20190410103644.036077691@linutronix.de> References: <20190410103644.036077691@linutronix.de> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/stacktrace] unicore32/stacktrace: Remove the pointless ULONG_MAX marker Git-Commit-ID: f8a9a269c28ddd5d741e747ceca753af01c828f2 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: f8a9a269c28ddd5d741e747ceca753af01c828f2 Gitweb: https://git.kernel.org/tip/f8a9a269c28ddd5d741e747ceca753af01c828f2 Author: Thomas Gleixner AuthorDate: Wed, 10 Apr 2019 12:27:59 +0200 Committer: Thomas Gleixner CommitDate: Sun, 14 Apr 2019 19:58:28 +0200 unicore32/stacktrace: Remove the pointless ULONG_MAX marker Terminating the last trace entry with ULONG_MAX is a completely pointless exercise and none of the consumers can rely on it because it's inconsistently implemented across architectures. In fact quite some of the callers remove the entry and adjust stack_trace.nr_entries afterwards. Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) Cc: Josh Poimboeuf Cc: Andy Lutomirski Cc: Steven Rostedt Cc: Alexander Potapenko Cc: Guan Xuetao Link: https://lkml.kernel.org/r/20190410103644.036077691@linutronix.de --- arch/unicore32/kernel/stacktrace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/unicore32/kernel/stacktrace.c b/arch/unicore32/kernel/stacktrace.c index 9976e767d51c..e37da8c6837b 100644 --- a/arch/unicore32/kernel/stacktrace.c +++ b/arch/unicore32/kernel/stacktrace.c @@ -120,8 +120,6 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace) } walk_stackframe(&frame, save_trace, &data); - if (trace->nr_entries < trace->max_entries) - trace->entries[trace->nr_entries++] = ULONG_MAX; } void save_stack_trace(struct stack_trace *trace)