From: "Tibor Billes" <tbilles@gmx.com>
To: "\"Ville Syrjälä\"" <ville.syrjala@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Possible regression in 3.17-rc2 in i915 driver
Date: Sun, 31 Aug 2014 15:57:52 +0200 [thread overview]
Message-ID: <trinity-308be27e-3d60-406a-9682-0c7f98712a4f-1409493472065@3capp-mailcom-bs04> (raw)
Hi!
I tried to upgrade my kernel from 3.16 to 3.17-rc2 and I found that my laptop
was unable to boot. The boot process hangs after 2-3 seconds (according to
timestamps of log messages). The last kernel log line I usually see is the
discovery of my touchpad: "input: SynPS/2 Synaptics TouchPad as
/devices/platform/i8042/serio2/input/input11".
I did a git bisect and it pointed me to the following commit:
commit 208bf9fdcd3575aa4a5d48b3e0295f7cdaf6fc44
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
Date: Mon Aug 11 13:15:35 2014 +0300
drm/i915: Fix locking for intel_enable_pipe_a()
intel_enable_pipe_a() gets called with all the modeset locks already
held (by drm_modeset_lock_all()), so trying to grab the same
locks using another drm_modeset_acquire_ctx is going to fail miserably.
Move most of the drm_modeset_acquire_ctx handling (init/drop/fini)
out from intel_{get,release}_load_detect_pipe() into the callers
(intel_{crt,tv}_detect()). Only the actual locking and backoff
handling is left in intel_get_load_detect_pipe(). And in
intel_enable_pipe_a() we just share the mode_config.acquire_ctx from
drm_modeset_lock_all() which is already holding all the relevant locks.
It's perfectly legal to lock the same ww_mutex multiple times using the
same ww_acquire_ctx. drm_modeset_lock() will convert the returned
-EALREADY into 0, so the caller doesn't need to do antyhing special.
Fixes a hang on resume on my 830.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
I tried booting with the above commit reverted on top of 3.17-rc2 and it
booted successfully.
I also did a MagicSyrq-W (Display list of blocked (D state) tasks) after the
boot process stopped (using plain 3.17-rc2, without reverting the above commit)
and it showed that plymouthd was blocked with the following call trace (hand
copied):
irq_exit
common_interrupt
schedule_preemt_disabled
__mutex_lock_slowpath
mutex_lock
drm_modeset_lock
drm_getconnector
drm_mode_getcrttc
drm_ioctl
...
This may have something to do with the hang or it may not, I don't know but is
related to drm locking so I thought it was a good idea to mention it.
My laptop is an old Fujitsu-Siemens Amilo M1450g, running Linux Mint 16.
Let me know if I can help further debug this issue.
Tibor Billes
next reply other threads:[~2014-08-31 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 13:57 Tibor Billes [this message]
2014-09-01 6:25 ` Possible regression in 3.17-rc2 in i915 driver Jani Nikula
2014-09-01 8:09 ` [PATCH] drm/i915: Fix lock dropping in intel_tv_detect() ville.syrjala
2014-09-01 8:50 ` [Intel-gfx] " Chris Wilson
2014-09-01 9:45 ` Ville Syrjälä
2014-09-01 10:02 ` Chris Wilson
2014-09-01 10:07 ` [PATCH v2] " ville.syrjala
2014-09-01 10:20 ` Chris Wilson
2014-09-01 10:36 ` Ville Syrjälä
2014-09-01 10:43 ` Chris Wilson
2014-09-02 7:41 ` Jani Nikula
2014-09-02 8:16 ` Ville Syrjälä
2014-09-02 8:26 ` Chris Wilson
2014-09-02 9:57 ` [PATCH v3] " ville.syrjala
2014-09-02 11:41 ` Jani Nikula
2014-09-01 20:19 ` [PATCH v2] " Tibor Billes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-308be27e-3d60-406a-9682-0c7f98712a4f-1409493472065@3capp-mailcom-bs04 \
--to=tbilles@gmx.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).