From: Frank Wunderlich <frank-w@public-files.de>
To: Rob Herring <robh@kernel.org>
Cc: "Frank Wunderlich" <linux@fw-web.de>,
linux-rockchip@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Peter Geis" <pgwipeout@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Greg Ungerer" <gerg@kernel.org>,
"René van Dorst" <opensource@vdorst.com>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>
Subject: Aw: Re: [PATCH v3 1/6] dt-bindings: net: dsa: convert binding for mediatek switches
Date: Wed, 11 May 2022 10:02:45 +0200 [thread overview]
Message-ID: <trinity-68761fe5-fcca-456b-ba50-ead759f0fb54-1652256165646@3c-app-gmx-bap47> (raw)
In-Reply-To: <YnqymzCbabEjV7GQ@robh.at.kernel.org>
Hi
thanks for review
> Gesendet: Dienstag, 10. Mai 2022 um 20:44 Uhr
> Von: "Rob Herring" <robh@kernel.org>
> On Sat, May 07, 2022 at 07:04:35PM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt7530
> > + - mediatek,mt7531
> > + - mediatek,mt7621
> > +
>
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
>
> I don't see any child nodes with addresses, so these can be removed.
dropping this (and address-cells/size-cells from examples) causes errors like this (address-/size-cells set in mdio
node, so imho it should inherite):
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.example.dts:34.25-35: Warning (reg_format):
/example-0/mdio/switch@0/ports/port@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
> > + interrupt-controller:
> > + type: boolean
>
> Already has a type. Just:
>
> interrupt-controller: true
>
> > +
> > + interrupts:
> > + maxItems: 1
> > +patternProperties:
> > + "^(ethernet-)?ports$":
> > + type: object
>
> additionalProperties: false
imho this will block address-/size-cells from this level too. looks like it is needed here too (for port-regs).
> > +
> > + patternProperties:
> > + "^(ethernet-)?port@[0-9]+$":
> > + type: object
> > + description: Ethernet switch ports
> > +
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + reg:
> > + description:
> > + Port address described must be 5 or 6 for CPU port and from 0
> > + to 5 for user ports.
> > +
> > + allOf:
> > + - $ref: dsa-port.yaml#
> > + - if:
> > + properties:
> > + label:
> > + items:
> > + - const: cpu
> > + then:
> > + required:
> > + - reg
> > + - phy-mode
> > +
> > + - if:
> > + required:
> > + - interrupt-controller
> > + then:
> > + required:
> > + - interrupts
>
> This can be expressed as:
>
> dependencies:
> interrupt-controller: [ interrupts ]
ok, i will change this
> > + ports {
>
> Use the preferred form: ethernet-ports
current implementation in all existing dts and examples from old binding are "ports" only.
should they changed too?
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
regards Frank
next prev parent reply other threads:[~2022-05-11 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 17:04 [PATCH v3 0/6] Support mt7531 on BPI-R2 Pro Frank Wunderlich
2022-05-07 17:04 ` [PATCH v3 1/6] dt-bindings: net: dsa: convert binding for mediatek switches Frank Wunderlich
2022-05-07 19:59 ` Krzysztof Kozlowski
2022-05-10 18:44 ` Rob Herring
2022-05-11 8:02 ` Frank Wunderlich [this message]
2022-05-18 1:54 ` Rob Herring
2022-05-07 17:04 ` [PATCH v3 2/6] net: dsa: mt7530: rework mt7530_hw_vlan_{add,del} Frank Wunderlich
2022-05-07 17:04 ` [PATCH v3 3/6] net: dsa: mt7530: rework mt753[01]_setup Frank Wunderlich
2022-05-07 17:04 ` [PATCH v3 4/6] net: dsa: mt7530: get cpu-port via dp->cpu_dp instead of constant Frank Wunderlich
2022-05-07 17:04 ` [PATCH v3 5/6] dt-bindings: net: dsa: make reset optional and add rgmii-mode to mt7531 Frank Wunderlich
2022-05-07 20:01 ` Krzysztof Kozlowski
2022-05-08 6:24 ` Frank Wunderlich
2022-05-08 9:41 ` Heiko Stuebner
2022-05-08 12:12 ` Aw: " Frank Wunderlich
2022-05-08 17:04 ` Peter Geis
2022-05-09 6:48 ` Krzysztof Kozlowski
2022-05-09 11:22 ` Peter Geis
2022-05-07 17:04 ` [PATCH v3 6/6] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Frank Wunderlich
2022-06-08 17:38 ` Aw: [PATCH v3 0/6] Support mt7531 on BPI-R2 Pro Frank Wunderlich
2022-06-08 17:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-68761fe5-fcca-456b-ba50-ead759f0fb54-1652256165646@3c-app-gmx-bap47 \
--to=frank-w@public-files.de \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gerg@kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).