From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbbICM0U (ORCPT ); Thu, 3 Sep 2015 08:26:20 -0400 Received: from mout.gmx.net ([212.227.15.18]:49358 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753273AbbICM0R (ORCPT ); Thu, 3 Sep 2015 08:26:17 -0400 MIME-Version: 1.0 Message-ID: From: "Helge Deller" To: "Mathieu Desnoyers" Cc: "Andrew Morton" , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-parisc@vger.kernel.org Subject: Re: [RFC PATCH 9/9] parisc: allocate sys_membarrier system call number Content-Type: text/plain; charset=UTF-8 Date: Thu, 3 Sep 2015 14:26:10 +0200 Importance: normal Sensitivity: Normal In-Reply-To: <1440698215-8355-10-git-send-email-mathieu.desnoyers@efficios.com> References: <1440698215-8355-1-git-send-email-mathieu.desnoyers@efficios.com>, <1440698215-8355-10-git-send-email-mathieu.desnoyers@efficios.com> X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K0:P0Q360iR/xa1o7J1v10OJ2ZQlzsyXsvljHN9R7kjD+H NBgYBO+KgCZcBm23IQk/mgtznsXsCZnUrpBk43JhPZOFBeGmzb fo3KWzMLx8QYOE+S7VZ6lPWuLQHHbg240VwhuzBX2pSXa4yRuW ZzsSSitFPdkWLZ9N48/tdPq1DiRzumjWF/Lnut+b+i3OpSLUV2 hA/H9tEodZ5lnXoEXvBiucGe6K0/7DwhFm4zIck8HnCTXFEYKR BiOiMRBZTsbkSyRWr3UtdIEKTlb3c+aP2YV5PcJcH11fNR0c7R oP/MBY= X-UI-Out-Filterresults: notjunk:1;V01:K0:iWfdY+Hrncc=:jpw3wEWIPQukrjwKOyGzGc DenPpdrgaQsJYHaSkg5Kfh1PPKwX0Mu1FlI3URKAsoiJ5Cd3/AUdMaWNb5Zq02pepwRElGCni pwdmyxpVniA1LFNHXnrflYHzY5KqpekKVDlOX2GLtI9L5xBMW/bjBhbjx0vkgvGaeB4nFTasn LtXAW4ZmXWyiA/qYIMej5AvTvhtTAQUMUvhXct4yxfg2J7/gY5chBPKcryTVNHyzZ8Bk/R/67 olVdHEcvs19qO6Kiq3aOE/Ld0wqozjY2Nu/4GhKllipu0TYtNVdmpffsSHMxQP2vJkd0JIGiu 5sSM+4EE61FPTtNbzs901KoZ256Anox6QXVTc0ziN3rldXacVSO7o6meQ/4ZI8sM11gOI08pq gJVXM7/AadCgksNLfpqleU8qFBpdt2cvQF+low4HOKehHN1Pkk18puJXd5uvbph9povARdX+X 3BCcVDuiRg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, > [ Untested on this architecture. To try it out: fetch linux-next/akpm, > apply this patch, build/run a membarrier-enabled kernel, and do make > kselftest. ] > > Signed-off-by: Mathieu Desnoyers > CC: Andrew Morton > CC: linux-api@vger.kernel.org > CC: "James E.J. Bottomley" > CC: Helge Deller > CC: linux-parisc@vger.kernel.org > --- > arch/parisc/include/uapi/asm/unistd.h | 3 ++- > arch/parisc/kernel/syscall_table.S | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h > index 2e639d7..dadcada 100644 > --- a/arch/parisc/include/uapi/asm/unistd.h > +++ b/arch/parisc/include/uapi/asm/unistd.h > @@ -358,8 +358,9 @@ > #define __NR_memfd_create (__NR_Linux + 340) > #define __NR_bpf (__NR_Linux + 341) > #define __NR_execveat (__NR_Linux + 342) > +#define __NR_membarrier (__NR_Linux + 343) > > -#define __NR_Linux_syscalls (__NR_execveat + 1) > +#define __NR_Linux_syscalls (__NR_membarrier + 1) > > > #define __IGNORE_select /* newselect */ > diff --git a/arch/parisc/kernel/syscall_table.S b/arch/parisc/kernel/syscall_table.S > index 8eefb12..2faa43b 100644 > --- a/arch/parisc/kernel/syscall_table.S > +++ b/arch/parisc/kernel/syscall_table.S > @@ -438,6 +438,7 @@ > ENTRY_SAME(memfd_create) /* 340 */ > ENTRY_SAME(bpf) > ENTRY_COMP(execveat) > + ENTRY_COMP(membarrier) This needs to be ENTRY_SAME(membarrier), since you don't have/need a compat_membarrier() function. After changing to ENTRY_SAME() I did run the kselftest on parisc: deller@ls3xx> ./membarrier_test membarrier MEMBARRIER_CMD_QUERY syscall available. membarrier: MEMBARRIER_CMD_SHARED success. membarrier: tests done! Helge