From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756969Ab0DHJbP (ORCPT ); Thu, 8 Apr 2010 05:31:15 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:60831 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab0DHJbL convert rfc822-to-8bit (ORCPT ); Thu, 8 Apr 2010 05:31:11 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=qm0xfDdzamGB5Ken9DE39KbDE45GSj/52cfuu41p3zNUB9btt3fPL/PCm5JJHy/i8i H/Z5JQ6WNpWbXUUIXlM4q4Mujf7487URfo02B80G7bGMTQwmIIdSA68YUSvrKKFVJwUZ 0nF5MwdIvXOyWNcaq/WL8ZeQ/C78nUiO/XhxM= MIME-Version: 1.0 In-Reply-To: <20100329104838.49c18075@feng-i7> References: <1269340105-6503-1-git-send-email-chripell@fsfe.org> <1269340170-6558-1-git-send-email-chripell@fsfe.org> <20100329104838.49c18075@feng-i7> Date: Thu, 8 Apr 2010 11:31:09 +0200 X-Google-Sender-Auth: b6c76b27548466d9 Message-ID: Subject: Re: [PATCH v1 3/4] max3100: adds console support for MAX3100 From: christian pellegrin To: Feng Tang Cc: "akpm@linux-foundation.org" , "greg@kroah.com" , "david-b@pacbell.net" , "grant.likely@secretlab.ca" , "alan@lxorguk.ukuu.org.uk" , "spi-devel-general@lists.sourceforge.net" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 29, 2010 at 4:48 AM, Feng Tang wrote: >> +             tx |= MAX3100_WD | MAX3100_RTS; > > Does this imply to have to work with HW flow control? on my platform > I have to remove the RTS bit to make it work. > Finally I had time to check this. If you compare the 8250 (or similar) data-sheet with the MAX31x0 one you see that the handling of the RTX/CTS bits is exactly the same (8250 about RTS bit for example: "When any of these bits are cleared, the associated output is forced high." and MAX3110: "Request-to-Send Bit. Controls the state of the RTS output. This bit is reset on power-up (RTS bit = 0 sets the RTS pin = logic high)."). If you look at the 8250.c driver (grep for UART_MCR_RTS) you notice that the bit is set on device open (together with DTR of course). So I think the driver is doing the right thing here. -- Christian Pellegrin, see http://www.evolware.org/chri/ "Real Programmers don't play tennis, or any other sport which requires you to change clothes. Mountain climbing is OK, and Real Programmers wear their climbing boots to work in case a mountain should suddenly spring up in the middle of the computer room."