From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263156AbTHVNnr (ORCPT ); Fri, 22 Aug 2003 09:43:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263167AbTHVNnr (ORCPT ); Fri, 22 Aug 2003 09:43:47 -0400 Received: from [213.187.195.158] ([213.187.195.158]:24815 "EHLO kokeicha.ingate.se") by vger.kernel.org with ESMTP id S263156AbTHVNnq (ORCPT ); Fri, 22 Aug 2003 09:43:46 -0400 To: Marcelo Tosatti Cc: "Gabor Z. Papp" , mostrows@speakeasy.net, linux-kernel@vger.kernel.org Subject: [PATCH] Re: PPPoE Oops with 2.4.22-rc References: <5ff3.3f388c4b.4453f@gzp1.gzp.hu> <39a.3f392c6f.86e8b@gzp1.gzp.hu> From: Marcus Sundberg Date: 22 Aug 2003 15:43:01 +0200 In-Reply-To: <39a.3f392c6f.86e8b@gzp1.gzp.hu> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, this patch fixes one crash in pppoe_connect(): --- linux-2.4.21-rc2/drivers/net/pppoe.c~ Wed May 14 00:08:52 2003 +++ linux-2.4.21-rc2/drivers/net/pppoe.c Wed May 14 00:18:47 2003 @@ -606,7 +606,8 @@ /* Delete the old binding */ delete_item(po->pppoe_pa.sid,po->pppoe_pa.remote); - dev_put(po->pppoe_dev); + if (po->pppoe_dev) + dev_put(po->pppoe_dev); memset(po, 0, sizeof(struct pppox_opt)); po->sk = sk; //Marcus -- ---------------------------------------+-------------------------- Marcus Sundberg | Firewalls with SIP & NAT Firewall Developer, Ingate Systems AB | http://www.ingate.com/