From: Vadym Kochan <vadym.kochan@plvision.eu>
To: "Jan Lübbe" <jlu@pengutronix.de>
Cc: Vadym Kochan <vadym.kochan@plvision.eu>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH v2 3/3] nvmem: add ONIE nvmem cells parser
Date: Wed, 08 Sep 2021 12:56:48 +0300 [thread overview]
Message-ID: <vrcxh2wnnrl7a7.fsf@plvision.eu> (raw)
In-Reply-To: <b54325f156eaaa6535667a1a7fb695c7688d2db4.camel@pengutronix.de>
Hi Jan,
Jan Lübbe <jlu@pengutronix.de> writes:
> Hi,
>
> On Tue, 2021-06-08 at 22:03 +0300, Vadym Kochan wrote:
>
> ...
>> + case 0x24: return "mac-address";
> ...
This is a base mac,
>> + case 0x2A: return "num-macs";
>
> Is suspect these properties define which range of MACs is assigned to the
Yes
> device. How would you use them to assign MAC addresses to multiple interfaces?
> The nvmem-cells property in the network device's node can only refer to one
> cell, and not to i.e the cells value + 1.
>
Currently in net/ethernet/marvell/prestera/prestera_main.c it is
incremented and hard-coded by the driver.
> I think it would be useful to have a way to express this setup for systems with
> many interfaces, but am unsure of where this should be described. Maybe a "mac-
> address-offset" property in the generic ethernet controller binding?
>
> Regards,
> Jan
May be something like eth_address_provider should be introduced in
net/ethernet/ ?
This provider can provide something like eth_provider_address_next() which
will consider "mac-address-num" (or other specific fields).
next prev parent reply other threads:[~2021-09-08 9:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 19:03 [PATCH v2 0/3] nvmem: add ONIE NVMEM cells parser Vadym Kochan
2021-06-08 19:03 ` [PATCH v2 1/3] nvmem: core: introduce " Vadym Kochan
2021-06-08 22:49 ` kernel test robot
2021-06-09 3:05 ` kernel test robot
2021-06-14 10:44 ` Srinivas Kandagatla
2021-06-16 12:33 ` Vadym Kochan
2021-06-21 11:00 ` Srinivas Kandagatla
2021-09-08 9:38 ` Vadym Kochan
2021-09-13 14:19 ` Srinivas Kandagatla
2021-09-20 10:24 ` Vadym Kochan
2021-09-20 10:36 ` Srinivas Kandagatla
2021-09-20 11:25 ` Vadym Kochan
2021-09-20 11:32 ` Srinivas Kandagatla
2021-09-20 12:29 ` Vadym Kochan
2021-09-20 12:34 ` Srinivas Kandagatla
2021-09-20 13:29 ` Vadym Kochan
2021-09-20 13:40 ` Srinivas Kandagatla
2021-09-21 5:50 ` John Thomson
2021-09-27 7:50 ` Vadym Kochan
2021-09-27 10:12 ` Srinivas Kandagatla
2021-09-28 13:31 ` Vadym Kochan
2021-09-28 13:51 ` Srinivas Kandagatla
2021-09-28 14:11 ` Vadym Kochan
2021-09-28 14:39 ` Srinivas Kandagatla
2021-09-27 10:12 ` Srinivas Kandagatla
2021-09-27 12:38 ` John Thomson
2021-09-08 9:44 ` Vadym Kochan
2021-06-08 19:03 ` [PATCH v2 2/3] dt-bindings: nvmem: document nvmem-cells-parser-name property Vadym Kochan
2021-06-18 20:59 ` Rob Herring
2021-06-08 19:03 ` [PATCH v2 3/3] nvmem: add ONIE nvmem cells parser Vadym Kochan
2021-08-06 15:39 ` Jan Lübbe
2021-09-08 9:56 ` Vadym Kochan [this message]
2021-09-12 21:06 ` John Thomson
2021-09-13 14:20 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vrcxh2wnnrl7a7.fsf@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=devicetree@vger.kernel.org \
--cc=jlu@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).