linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re:  [PATCH] media: dt-bindings: media: venus: Add firmware-name
@ 2021-07-14 18:13 Yassine Oudjana
  0 siblings, 0 replies; 2+ messages in thread
From: Yassine Oudjana @ 2021-07-14 18:13 UTC (permalink / raw)
  To: Rob Herring
  Cc: Stanimir Varbanov, devicetree, Andy Gross, Bjorn Andersson,
	Mauro Carvalho Chehab, linux-arm-msm, linux-media, linux-kernel,
	~postmarketos/upstreaming

On Wednesday, July 14th, 2021 at 10:03 PM, Rob Herring <robh@kernel.org> wrote:

> On Tue, Jun 22, 2021 at 04:20:24PM +0000, Yassine Oudjana wrote:
>
> > Date: Tue, 22 Jun 2021 20:08:25 +0400
> >
> > Subject: [PATCH] media: dt-bindings: media: venus: Add firmware-name
> >
> > Support for parsing the firmware-name property was added a while ago 1,
> >
> > but the dt-bindings were never updated with the new property. This patch
> >
> > adds it to all venus dt-bindings.
> >
> > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com
> >
> > .../devicetree/bindings/media/qcom,msm8916-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,msm8996-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sc7180-venus.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 5 +++++
> >
> > .../devicetree/bindings/media/qcom,sdm845-venus.yaml | 5 +++++
> >
> > 5 files changed, 25 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > index 59ab16ad12f1..cb1b866d9c37 100644
> >
> > --- a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
> >
> > @@ -80,6 +80,11 @@ properties:
> >
> > required:
> >
> > - iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
>
> Not an array.
>
Noted.

> Is there a specific pattern and/or default name you can specify?
>
The pattern is usually something like "qcom/<soc>/<device>/venus.mbn", but it can be any path really.
The default would be to not set this property.

> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     index 199f45217b4a..b8809325138f 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
> >
> >     @@ -107,6 +107,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     index 04013e5dd044..ffd3e2850366 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
> >
> >     @@ -99,6 +99,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     index 04b9af4db191..cd7a5e1374ce 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
> >
> >     @@ -94,6 +94,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     index 680f37726fdf..ae256238a637 100644
> >
> >     --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
> >
> >     @@ -108,6 +108,11 @@ properties:
> >
> >     required:
> >     -   iommus
> >
> > -   firmware-name:
> > -   maxItems: 1
> > -   description: |
> > -        Relative firmware image path for venus.
> >
> >
> >
> > required:
> >
> > -   compatible
> > -   reg
> >
> >     --
> >
> >     2.32.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] media: dt-bindings: media: venus: Add firmware-name
@ 2021-06-22 16:25 Yassine Oudjana
  0 siblings, 0 replies; 2+ messages in thread
From: Yassine Oudjana @ 2021-06-22 16:25 UTC (permalink / raw)
  To: Stanimir Varbanov, Rob Herring, devicetree
  Cc: Yassine Oudjana, Andy Gross, Bjorn Andersson,
	Mauro Carvalho Chehab, linux-arm-msm, linux-media, linux-kernel,
	~postmarketos/upstreaming

Support for parsing the firmware-name property was added a while ago [1],
but the dt-bindings were never updated with the new property. This patch
adds it to all venus dt-bindings.

Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>

[1]: https://lore.kernel.org/linux-arm-msm/20210126084252.238078-1-stanimir.varbanov@linaro.org/
---
 .../devicetree/bindings/media/qcom,msm8916-venus.yaml        | 5 +++++
 .../devicetree/bindings/media/qcom,msm8996-venus.yaml        | 5 +++++
 .../devicetree/bindings/media/qcom,sc7180-venus.yaml         | 5 +++++
 .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml      | 5 +++++
 .../devicetree/bindings/media/qcom,sdm845-venus.yaml         | 5 +++++
 5 files changed, 25 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
index 59ab16ad12f1..cb1b866d9c37 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml
@@ -80,6 +80,11 @@ properties:
     required:
       - iommus
 
+  firmware-name:
+    maxItems: 1
+    description: |
+      Relative firmware image path for venus.
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
index 199f45217b4a..b8809325138f 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml
@@ -107,6 +107,11 @@ properties:
     required:
       - iommus
 
+  firmware-name:
+    maxItems: 1
+    description: |
+      Relative firmware image path for venus.
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
index 04013e5dd044..ffd3e2850366 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
@@ -99,6 +99,11 @@ properties:
     required:
       - iommus
 
+  firmware-name:
+    maxItems: 1
+    description: |
+      Relative firmware image path for venus.
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
index 04b9af4db191..cd7a5e1374ce 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
@@ -94,6 +94,11 @@ properties:
     required:
       - iommus
 
+  firmware-name:
+    maxItems: 1
+    description: |
+      Relative firmware image path for venus.
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
index 680f37726fdf..ae256238a637 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus.yaml
@@ -108,6 +108,11 @@ properties:
     required:
       - iommus
 
+  firmware-name:
+    maxItems: 1
+    description: |
+      Relative firmware image path for venus.
+
 required:
   - compatible
   - reg
-- 
2.32.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-14 18:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 18:13 [PATCH] media: dt-bindings: media: venus: Add firmware-name Yassine Oudjana
  -- strict thread matches above, loose matches on Subject: below --
2021-06-22 16:25 Yassine Oudjana

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).