archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <>
To: Christoph Hellwig <>
Cc: Alan Cox <>,
Subject: Re: [PATCH] aha1740 update
Date: 24 Apr 2003 15:34:25 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

>>>>> "CH" == Christoph Hellwig <> writes:

>> +/* This should really fit in driver/scsi/scsi.h, along with
>> + * scsi_to_{pci,sbus}_dma_dir.... */

CH> Right.  Please submit a patch to James.

I think this would cause some troubles. I would have to include
linux/dma-mapping in driver/scsi/scsi.h, but many non-PCI
architectures are still including asm-generic/dma-mapping.h, which has
lots of references to PCI functions... I'm afraid this would clash
badly on, say, sparc or m68k...

CH> Well, and as you're touching the driver big time a cleanup to follow
CH> Documentation/CondingStyle would be nice.

I totally agree with the rest of your comments, and will submit an
updated patch shortly.


Places change, faces change. Life is so very strange.

  reply	other threads:[~2003-04-24 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24 12:03 [PATCH] aha1740 update Marc Zyngier
2003-04-24 12:36 ` Christoph Hellwig
2003-04-24 13:34   ` Marc Zyngier [this message]
2003-04-24 13:39     ` Christoph Hellwig
2003-04-25 13:24   ` [PATCH] aha1740 update, take #2 Marc Zyngier
2003-04-25 13:40     ` Christoph Hellwig
2003-04-24 18:49 ` [PATCH] aha1740 update Alan Cox
2003-04-25  9:56   ` Marc Zyngier
2003-04-25  9:02     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).