From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323Ab0DTJu0 (ORCPT ); Tue, 20 Apr 2010 05:50:26 -0400 Received: from mail-qy0-f179.google.com ([209.85.221.179]:59205 "EHLO mail-qy0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754078Ab0DTJuZ convert rfc822-to-8bit (ORCPT ); Tue, 20 Apr 2010 05:50:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=vFQpKac6WVzXMZeNKz165+SLbPi5qBOhszMNZIvlipQhuVMj8R7PoinZrAbh3o/bSG JJy23IhwcL7REYOE4CKqzAU2PNJMQliMM18Tx3F5heA1xILpyCLdifFY9V2PdnNZD4ei RSgzyieDmVeyoywdsveQj9dAVekRt2dDc3NYM= MIME-Version: 1.0 In-Reply-To: <20100420084454.GD19264@csn.ul.ie> References: <201004152210.o3FMA7KV001909@imap1.linux-foundation.org> <20100419190133.50a13021.kamezawa.hiroyu@jp.fujitsu.com> <20100419181442.GA19264@csn.ul.ie> <20100419193919.GB19264@csn.ul.ie> <20100420082057.GC19264@csn.ul.ie> <20100420084454.GD19264@csn.ul.ie> Date: Tue, 20 Apr 2010 18:50:23 +0900 Message-ID: Subject: Re: error at compaction (Re: mmotm 2010-04-15-14-42 uploaded From: Minchan Kim To: Mel Gorman Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "linux-mm@kvack.org" , "kosaki.motohiro@jp.fujitsu.com" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 20, 2010 at 5:44 PM, Mel Gorman wrote: > On Tue, Apr 20, 2010 at 05:32:13PM +0900, Minchan Kim wrote: >> >> Yes. Then, Let's add comment like split_page. :) >>  /* >>  * Note: this is probably too low level an operation for use in drivers. >>  * Please consult with lkml before using this in your driver. >>  */ >> > > I can, but the comment that was there says it's like split_page except the > page is already free. This also covers not using it in a driver. I see. In addition, you already mentioned "As this is only being used for migration". I missed one. I don't have any against one. Will you repost v2 which move split_free_pages out of compaction.c? Anyway, feel free to add my reviewed-by sign. Thanks, Mel. Reviewed-by: Minchan Kim > > -- > Mel Gorman > Part-time Phd Student                          Linux Technology Center > University of Limerick                         IBM Dublin Software Lab > -- Kind regards, Minchan Kim