From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340AbbJUNkH (ORCPT ); Wed, 21 Oct 2015 09:40:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbbJUNkB (ORCPT ); Wed, 21 Oct 2015 09:40:01 -0400 From: Jeff Moyer To: Christoph Hellwig Cc: Ming Lin , lkml , Jens Axboe , Kent Overstreet , Dongsu Park , Mike Snitzer , "Martin K. Petersen" , Ming Lin , linux-nvme@lists.infradead.org Subject: Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} References: <1439363241-31772-1-git-send-email-mlin@kernel.org> <1439363241-31772-6-git-send-email-mlin@kernel.org> <20151013115011.GA6546@infradead.org> <20151021072126.GA7671@infradead.org> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 21 Oct 2015 09:39:58 -0400 In-Reply-To: <20151021072126.GA7671@infradead.org> (Christoph Hellwig's message of "Wed, 21 Oct 2015 00:21:26 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > Jens, Ming: > > are you fine with the one liner change to get back to the old I/O > pattern? While it looks like the cards fault I'd like to avoid this > annoying regression. I'm not Jens or Ming, but your patch looks fine to me, though you'll want to remove the MAX_BIO_SECTORS definition since it's now unused. It's not clear to me why the limit was lowered in the first place. You can add my Reviewed-by: Jeff Moyer if you resend the patch. -Jeff