From: Jeff Moyer <jmoyer@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: zach.brown@oracle.com, akpm@linux-foundation.org,
torvalds@linux-foundation.org, jdike@addtoit.com,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.24 BUG] 100% iowait on host while UML is running
Date: Mon, 03 Dec 2007 11:55:16 -0500 [thread overview]
Message-ID: <x49ir3fhg5n.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <E1IzDHv-0003xj-Af@dorka.pomaz.szeredi.hu> (Miklos Szeredi's message of "Mon\, 03 Dec 2007 16\:32\:51 +0100")
Miklos Szeredi <miklos@szeredi.hu> writes:
> On 2.6.24, top started showing 100% iowait on one CPU when a UML
> instance was running (but completely idle). I've traced it to this
> commit [1]. Reverting it cures the problem.
Hi,
The UML code sits in io_getevents waiting for an event to be submitted
and completed. This is a case I completely overlooked when putting
together the referenced patch.
We could check ctx->reqs_active before scheduling to determine whether
or not we are waiting for I/O, but this would require taking the
context lock in order to be accurate. Given that the test would be
only for the sake of book keeping, it might be okay to do it outside
of the lock.
Zach, what are your thoughts on this?
-Jeff
[1] commit 41d10da3717409de33d5441f2f6d8f072ab3fbb6
next prev parent reply other threads:[~2007-12-03 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 15:32 [2.6.24 BUG] 100% iowait on host while UML is running Miklos Szeredi
2007-12-03 16:55 ` Jeff Moyer [this message]
2007-12-03 18:53 ` Zach Brown
2007-12-03 19:33 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49ir3fhg5n.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).