From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934866AbbEOUZl (ORCPT ); Fri, 15 May 2015 16:25:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934443AbbEOUZj (ORCPT ); Fri, 15 May 2015 16:25:39 -0400 From: Jeff Moyer To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Robert Moore , linux-kernel@vger.kernel.org Subject: Re: [Linux-nvdimm] [PATCH v2 03/20] nd_acpi, nfit-test: manufactured NFITs for interface development References: <20150428181203.35812.60474.stgit@dwillia2-desk3.amr.corp.intel.com> <20150428182428.35812.95800.stgit@dwillia2-desk3.amr.corp.intel.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 15 May 2015 16:25:34 -0400 In-Reply-To: <20150428182428.35812.95800.stgit@dwillia2-desk3.amr.corp.intel.com> (Dan Williams's message of "Tue, 28 Apr 2015 14:24:29 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Williams writes: > +config NFIT_TEST > + tristate "NFIT TEST: Manufactured NFIT for interface testing" > + depends on DMA_CMA > + depends on LIBND=m > + depends on ND_ACPI > + depends on m > + help > + For development purposes register a manufactured > + NFIT table to verify the resulting device model topology. > + Note, this module arranges for ioremap_cache() to be > + overridden locally to allow simulation of system-memory as an > + io-memory-resource. > + > + Note, this test expects to be able to find at least 256MB of > + CMA space (CONFIG_CMA_SIZE_MBYTES, cma=) or it will fail to > + load. > + > + Say N unless you are doing development of the 'nd' subsystem. > + Too many TLAs. I'm guessing CMA means Conventional Memory Area to you. To me it means contiguous memory allocator. Anyway, please define acronyms when you use them, especially in help text. The help text also doesn't really explain where it will find this memory. Would it be possible to provide more direction there? I don't have any useful commentary on the patch itself. I do wonder if you shouldn't move this to the end, as it's hardly an integral part of the patch set. Cheers, Jeff