linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
	Ming Lin <mlin@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: remove BIO_EOPNOTSUPP
Date: Fri, 24 Apr 2015 16:31:29 -0400	[thread overview]
Message-ID: <x49r3r9xo7y.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1429904462-16998-1-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Fri, 24 Apr 2015 21:41:01 +0200")

Christoph Hellwig <hch@lst.de> writes:

> Since the big barrier rewrite/removal in 2007 we never fail FLUSH or
> FUA requests, which means we can remove the magic BIO_EOPNOTSUPP flag
> to help propagating those to the buffer_head layer.

I had a look through the kernel, checking for places where maybe we were
relying on an EOPNOTSUPP from REQ_DISCARD, just to ensure you weren't
pulling out an error path that could still be used.  I think everything
checks out.

> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 992ef58..c2ee937 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -118,7 +118,6 @@ struct bio {
>  #define BIO_CLONED	4	/* doesn't own data */
>  #define BIO_BOUNCED	5	/* bio is a bounce bio */
>  #define BIO_USER_MAPPED 6	/* contains user pages */
> -#define BIO_EOPNOTSUPP	7	/* not supported */
>  #define BIO_NULL_MAPPED 8	/* contains invalid user pages */
>  #define BIO_QUIET	9	/* Make BIO Quiet */
>  #define BIO_SNAP_STABLE	10	/* bio data must be snapshotted during write */

Should we leave a hole in the numbering scheme?

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

  parent reply	other threads:[~2015-04-24 20:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 19:41 [PATCH 1/2] block: remove BIO_EOPNOTSUPP Christoph Hellwig
2015-04-24 19:41 ` [PATCH 2/2] block: remove unused BIO_RW_BLOCK and BIO_EOF flags Christoph Hellwig
2015-04-24 19:47   ` Jeff Moyer
2015-04-24 19:53     ` Christoph Hellwig
2015-04-24 20:33       ` Jeff Moyer
2015-04-24 21:32   ` Tejun Heo
2015-04-24 20:31 ` Jeff Moyer [this message]
2015-04-24 21:31 ` [PATCH 1/2] block: remove BIO_EOPNOTSUPP Tejun Heo
2015-05-19  6:39 ` Christoph Hellwig
2015-05-19 15:19   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49r3r9xo7y.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlin@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).