From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966AbcFGNnA (ORCPT ); Tue, 7 Jun 2016 09:43:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38362 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754039AbcFGNm6 (ORCPT ); Tue, 7 Jun 2016 09:42:58 -0400 From: Jeff Moyer To: Minfei Huang Cc: axboe@fb.com, ming.lei@canonical.com, viro@zeniv.linux.org.uk, sagig@mellanox.com, mszeredi@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] loop: Make user notify for adding loop device failed References: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 07 Jun 2016 09:42:56 -0400 In-Reply-To: <1465265115-12479-1-git-send-email-mnghuan@gmail.com> (Minfei Huang's message of "Tue, 7 Jun 2016 10:05:15 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 07 Jun 2016 13:42:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minfei Huang writes: > There is no error number returned if loop driver fails in function > alloc_disk to add new loop device. Add a correct error number to make > user notify in this case. > > Signed-off-by: Minfei Huang > --- > drivers/block/loop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 1fa8cc2..2caaf6f 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1765,6 +1765,7 @@ static int loop_add(struct loop_device **l, int i) > */ > queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue); > > + err = -ENOMEM; > disk = lo->lo_disk = alloc_disk(1 << part_shift); > if (!disk) > goto out_free_queue; Looks good. Reviewed-by: Jeff Moyer