From: Jeff Moyer <jmoyer@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
axboe@kernel.dk, tytso@mit.edu, bpm@sgi.com,
viro@zeniv.linux.org.uk, jack@suse.cz,
linux-fsdevel@vger.kernel.org, hch@infradead.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
xfs@oss.sgi.com, djwong+kernel@djwong.org
Subject: Re: [PATCH 4/9] xfs: honor the O_SYNC flag for aysnchronous direct I/O requests
Date: Tue, 20 Nov 2012 14:42:48 -0500 [thread overview]
Message-ID: <x49wqxghxhj.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20121120112038.GC2591@dastard> (Dave Chinner's message of "Tue, 20 Nov 2012 22:20:38 +1100")
Dave Chinner <david@fromorbit.com> writes:
> And requeuing work from one workqueue to the next is something that
> we can avoid. We know at IO submission time (i.e.
> xfs_vm_direct_io)) whether an fsync completion is going to be needed
> during Io completion. The ioend->io_needs_fsync flag can be set
> then, and the first pass through xfs_finish_ioend() can queue it to
> the correct workqueue. i.e. it only needs to be queued if it's not
> already an unwritten or append ioend and it needs an fsync.
>
> As it is, all the data completion workqueues run the same completion
> function so all you need to do is handle the fsync case at the end
> of the existing processing - it's not an else case. i.e the end of
> xfs_end_io() becomes:
>
> if (ioend->io_needs_fsync) {
> error = xfs_ioend_fsync(ioend);
> if (error)
> ioend->io_error = -error;
> goto done;
> }
> done:
> xfs_destroy_ioend(ioend);
Works for me, that makes things simpler.
> As it is, this code is going to change before these changes go in -
> there's a nasty regression in the DIO code that I found this
> afternoon that requires reworking this IO completion logic to
> avoid. The patch will appear on the list soon....
I'm not on the xfs list, so if you haven't already sent it, mind Cc-ing
me?
>> --- a/fs/xfs/xfs_mount.h
>> +++ b/fs/xfs/xfs_mount.h
>> @@ -209,6 +209,7 @@ typedef struct xfs_mount {
>> struct workqueue_struct *m_data_workqueue;
>> struct workqueue_struct *m_unwritten_workqueue;
>> struct workqueue_struct *m_cil_workqueue;
>> + struct workqueue_struct *m_aio_blkdev_flush_wq;
>
> struct workqueue_struct *m_aio_fsync_wq;
For the record, m_aio_blkdev_flush_wq is the name you chose previously.
;-)
Thanks for the review!
Cheers,
Jeff
next prev parent reply other threads:[~2012-11-20 19:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 7:41 [PATCH v1 0/9] fs: fix up AIO+DIO+O_SYNC to actually do the sync part Darrick J. Wong
2012-11-20 7:41 ` [PATCH 1/9] vfs: Handle O_SYNC AIO DIO in generic code properly Darrick J. Wong
2012-11-21 10:08 ` Christoph Hellwig
2012-11-21 16:58 ` Jeff Moyer
2012-11-21 18:29 ` Christoph Hellwig
2012-11-21 18:38 ` Jeff Moyer
2012-11-21 21:37 ` Jan Kara
2012-11-21 23:09 ` Jeffrey Ellis
2012-11-20 7:41 ` [PATCH 2/9] ext4: honor the O_SYNC flag for aysnchronous direct I/O requests Darrick J. Wong
2012-11-20 10:07 ` Jan Kara
2012-11-20 20:02 ` Jeff Moyer
2012-11-21 0:56 ` Jan Kara
2012-11-21 14:09 ` Jeff Moyer
2012-11-21 16:54 ` Jan Kara
2012-11-20 7:41 ` [PATCH 3/9] xfs: factor out everything but the filemap_write_and_wait from xfs_file_fsync Darrick J. Wong
2012-11-20 10:47 ` Dave Chinner
2012-11-21 10:09 ` Christoph Hellwig
2012-11-21 14:10 ` Jeff Moyer
2012-11-20 7:51 ` [PATCH 7/9] ocfs2: Use generic handlers of O_SYNC AIO DIO Darrick J. Wong
2012-11-21 19:32 ` Joel Becker
2012-11-20 7:51 ` [PATCH 5/9] btrfs: " Darrick J. Wong
2012-11-20 7:51 ` [PATCH 6/9] gfs2: " Darrick J. Wong
2012-11-20 7:51 ` [PATCH 4/9] xfs: honor the O_SYNC flag for aysnchronous direct I/O requests Darrick J. Wong
2012-11-20 10:24 ` Jan Kara
2012-11-20 11:20 ` Dave Chinner
2012-11-20 19:42 ` Jeff Moyer [this message]
2012-11-20 20:08 ` Dave Chinner
2012-11-20 7:51 ` [PATCH 8/9] filemap: don't call generic_write_sync for -EIOCBQUEUED Darrick J. Wong
2012-11-20 7:51 ` [PATCH 9/9] blkdev: Fix up AIO+DIO+O_SYNC to do the sync part correctly Darrick J. Wong
2012-11-20 10:15 ` Jan Kara
2012-11-20 20:47 ` Jeff Moyer
2012-11-21 0:57 ` Jan Kara
2012-11-20 8:38 ` [PATCH v1 0/9] fs: fix up AIO+DIO+O_SYNC to actually do the sync part Darrick J. Wong
2012-11-20 14:23 ` Jeff Moyer
2012-11-20 18:57 ` Darrick J. Wong
2012-11-20 19:05 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49wqxghxhj.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bpm@sgi.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong+kernel@djwong.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).