From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbcEKMau (ORCPT ); Wed, 11 May 2016 08:30:50 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35976 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbcEKMar convert rfc822-to-8bit (ORCPT ); Wed, 11 May 2016 08:30:47 -0400 From: Michal Nazarewicz To: Felipe Balbi , changbin.du@intel.com Cc: gregkh@linuxfoundation.org, rui.silva@linaro.org, k.opasiak@samsung.com, lars@metafoo.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Du\, Changbin" Subject: Re: [PATCH] usb: gadget: f_fs: report error if excess data received In-Reply-To: <87twi4g8s2.fsf@linux.intel.com> Organization: http://mina86.com/ References: <1462961970-2001-1-git-send-email-changbin.du@intel.com> <87twi4g8s2.fsf@linux.intel.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix,O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160511:linux-kernel@vger.kernel.org::AevogXTs1lSjgBPM:0000000000000000000000000000000001GrF X-Hashcash: 1:20:160511:rui.silva@linaro.org::ejpvq7E6ebePXOqO:000000000000000000000000000000000000000001Umv X-Hashcash: 1:20:160511:gregkh@linuxfoundation.org::0Lp/Ch/7SJ0jD+8z:0000000000000000000000000000000000006V0 X-Hashcash: 1:20:160511:balbi@kernel.org::WcVSdniPhL2EUcKU:00cUu X-Hashcash: 1:20:160511:changbin.du@intel.com::I6FlCfgbgcbO+PdY:00000000000000000000000000000000000000003J7M X-Hashcash: 1:20:160511:linux-usb@vger.kernel.org::AC6xbazMzZlutX53:0000000000000000000000000000000000005BWl X-Hashcash: 1:20:160511:k.opasiak@samsung.com::UXmiwJLQorP5msSR:00000000000000000000000000000000000000005YY7 X-Hashcash: 1:20:160511:changbin.du@intel.com::Yjj0l1cOYwVlFc3b:00000000000000000000000000000000000000006xro X-Hashcash: 1:20:160511:lars@metafoo.de::jYulI1IBy9fs5lxY:009BFE Date: Wed, 11 May 2016 14:30:44 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11 2016, Felipe Balbi wrote: > Also, returning -EOVERFLOW is not exactly correct here, because you'd > violate POSIX specification of read(), right ? Maybe we could piggyback on: EINVAL fd was created via a call to timerfd_create(2) and the wrong size buffer was given to read(); But I kinda agree. I’m not sure how much we need to care about this instead of having user space round their buffers up to the nearest max packet size boundary. -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»