From: Michal Nazarewicz <mina86@mina86.com>
To: Gioh Kim <gioh.kim@lge.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Minchan Kim <minchan.kim@lge.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Rik van Riel" <riel@redhat.com>,
"Laura Abbott" <lauraa@codeaurora.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Heesub Shin" <heesub.shin@samsung.com>,
"Mel Gorman" <mgorman@suse.de>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
이건호 <gunho.lee@lge.com>,
gurugio@gmail.com
Subject: Re: [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value
Date: Fri, 16 May 2014 10:45:12 -0700 [thread overview]
Message-ID: <xa1tppjdfwif.fsf@mina86.com> (raw)
In-Reply-To: <5375C619.8010501@lge.com>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On Fri, May 16 2014, Gioh Kim wrote:
> If CMA_SIZE_MBYTES is allowed to be zero, there should be defense code
> to check CMA is initlaized correctly. And atomic_pool initialization
> should be done by __alloc_remap_buffer instead of
> __alloc_from_contiguous if __alloc_from_contiguous is failed.
Agreed, and this is the correct fix.
> IMPO, it is more simple and powerful to restrict CMA_SIZE_MBYTES_MAX
> configuration to be larger than zero.
No, because it makes it impossible to have CMA disabled by default and
only enabled if command line argument is given.
Furthermore, your patch does *not* guarantee CMA region to always be
allocated. If CMA_SIZE_SEL_PERCENTAGE is selected for instance. Or if
user explicitly passes 0 on command line.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
[-- Attachment #2.1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2014-05-16 17:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 0:32 [RFC PATCH 0/3] Aggressively allocate the pages on cma reserved memory Joonsoo Kim
2014-05-08 0:32 ` [RFC PATCH 1/3] CMA: remove redundant retrying code in __alloc_contig_migrate_range Joonsoo Kim
2014-05-09 15:44 ` Michal Nazarewicz
2014-05-08 0:32 ` [RFC PATCH 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used Joonsoo Kim
2014-05-09 15:45 ` Michal Nazarewicz
2014-05-12 17:04 ` Laura Abbott
2014-05-13 1:14 ` Joonsoo Kim
2014-05-13 3:05 ` Minchan Kim
2014-05-24 0:57 ` Laura Abbott
2014-05-26 2:44 ` Joonsoo Kim
2014-05-13 3:00 ` Minchan Kim
2014-05-15 1:53 ` Joonsoo Kim
2014-05-15 2:43 ` Minchan Kim
2014-05-19 2:11 ` Joonsoo Kim
2014-05-19 2:53 ` Minchan Kim
2014-05-19 4:50 ` Joonsoo Kim
2014-05-19 23:18 ` Minchan Kim
2014-05-20 6:33 ` Joonsoo Kim
2014-05-15 2:45 ` Heesub Shin
2014-05-15 5:06 ` Minchan Kim
2014-05-19 23:22 ` Minchan Kim
2014-05-16 8:02 ` [RFC][PATCH] CMA: drivers/base/Kconfig: restrict CMA size to non-zero value Gioh Kim
2014-05-16 17:45 ` Michal Nazarewicz [this message]
2014-05-19 1:47 ` Gioh Kim
2014-05-19 5:55 ` Joonsoo Kim
2014-05-19 9:14 ` Gioh Kim
2014-05-19 19:59 ` Michal Nazarewicz
2014-05-20 0:50 ` Gioh Kim
2014-05-20 1:28 ` Michal Nazarewicz
2014-05-20 2:26 ` Gioh Kim
2014-05-20 18:15 ` Michal Nazarewicz
2014-05-20 11:38 ` Marek Szyprowski
2014-05-21 0:15 ` Gioh Kim
2014-05-14 8:42 ` [RFC PATCH 2/3] CMA: aggressively allocate the pages on cma reserved memory when not used Aneesh Kumar K.V
2014-05-15 1:58 ` Joonsoo Kim
2014-05-18 17:36 ` Aneesh Kumar K.V
2014-05-19 2:29 ` Joonsoo Kim
2014-05-08 0:32 ` [RFC PATCH 3/3] CMA: always treat free cma pages as non-free on watermark checking Joonsoo Kim
2014-05-09 15:46 ` Michal Nazarewicz
2014-05-09 12:39 ` [RFC PATCH 0/3] Aggressively allocate the pages on cma reserved memory Marek Szyprowski
2014-05-13 2:26 ` Joonsoo Kim
2014-05-14 9:44 ` Aneesh Kumar K.V
2014-05-15 2:10 ` Joonsoo Kim
2014-05-15 9:47 ` Mel Gorman
2014-05-19 2:12 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tppjdfwif.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=gioh.kim@lge.com \
--cc=gunho.lee@lge.com \
--cc=gurugio@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=heesub.shin@samsung.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=minchan.kim@lge.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).