From: Valentin Schneider <vschneid@redhat.com>
To: Vincent Donnefort <vdonnefort@google.com>,
peterz@infradead.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, regressions@leemhuis.info,
kernel-team@android.com,
Vincent Donnefort <vdonnefort@google.com>,
Derek Dolney <z23@posteo.net>
Subject: Re: [PATCH v4] cpu/hotplug: Do not bail-out in DYING/STARTING sections
Date: Tue, 19 Jul 2022 16:12:03 +0100 [thread overview]
Message-ID: <xhsmhfsix6ssc.mognet@vschneid.remote.csb> (raw)
In-Reply-To: <20220704131346.2650163-1-vdonnefort@google.com>
On 04/07/22 14:13, Vincent Donnefort wrote:
> +static int _cpuhp_invoke_callback_range(bool bringup,
> + unsigned int cpu,
> + struct cpuhp_cpu_state *st,
> + enum cpuhp_state target,
> + bool nofail)
[...]
> + if (nofail) {
> + pr_warn("CPU %u %s state %s (%d) failed (%d)\n",
> + cpu, bringup ? "UP" : "DOWN",
> + cpuhp_get_step(st->state)->name,
> + st->state, err);
> + ret = -1;
On a single failure we'll get two warns (WARN_ON_ONCE() + pr_warn(), and
then subsequently just the pr_warn()), is that intended?
Also, why not have ret = err here?
> + } else {
> + ret = err;
> break;
> + }
> }
>
> - return err;
> + return ret;
> +static inline void cpuhp_invoke_callback_range_nofail(bool bringup,
> + unsigned int cpu,
> + struct cpuhp_cpu_state *st,
> + enum cpuhp_state target)
> +{
> + WARN_ON_ONCE(_cpuhp_invoke_callback_range(bringup, cpu, st, target, true));
> }
>
next prev parent reply other threads:[~2022-07-19 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 13:13 [PATCH v4] cpu/hotplug: Do not bail-out in DYING/STARTING sections Vincent Donnefort
2022-07-19 15:12 ` Valentin Schneider [this message]
2022-07-19 15:48 ` Vincent Donnefort
2022-07-22 18:35 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhsmhfsix6ssc.mognet@vschneid.remote.csb \
--to=vschneid@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=regressions@leemhuis.info \
--cc=tglx@linutronix.de \
--cc=vdonnefort@google.com \
--cc=z23@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).