From: bsegall@google.com
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: peterz@infradead.org, mingo@redhat.com, dietmar.eggemann@arm.com,
pjt@google.com, vincent.guittot@linaro.org,
nicolas.pitre@linaro.org, mturquette@linaro.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] sched: Track sched_entity usage contributions
Date: Mon, 22 Sep 2014 10:09:42 -0700 [thread overview]
Message-ID: <xm267g0vlgyx.fsf@sword-of-the-dawn.mtv.corp.google.com> (raw)
In-Reply-To: <1411403047-32010-8-git-send-email-morten.rasmussen@arm.com> (Morten Rasmussen's message of "Mon, 22 Sep 2014 17:24:07 +0100")
Morten Rasmussen <morten.rasmussen@arm.com> writes:
> Adds usage contribution tracking for both task and group entities.
> Maintains a non-priority scaled se->avg.usage_avg_contrib for each
> sched_entity and cfs_rq.usage_util_avg sum of all entity contributions.
> The latter provides a more accurate estimate of the true cpu utilization
> than the existing cfs_rq.runnable_load_avg (+blocked_load_avg).
>
> Unlike se->avg.load_avg_contrib, se->avg.usage_avg_contrib for group
> entities is the sum of se->avg.usage_avg_contrib for all entities on the
> group runqueue. It is _not_ influenced in any way by the task group
> h_load. Hence it is representing the actual cpu usage of the group, not
> its intended load contribution which may differ significantly from the
> usage on lightly utilized systems.
>
> The cpu usage tracking is available as cpu_rq(cpu)->cfs.usage_util_avg.
> No tracking of blocked usage has been implemented.
Isn't cfs_rq->usage_util_avg basically just
se->avg.usage_avg_sum * 1024 / se->avg.runnable_avg_period, where
se->group_cfs_rq == cfs_rq? (and for the rq as a whole, rq->avg)
The fact that usage_util_avg doesn't track blocked usage seems more
likely to be a problem than an advantage, but maybe not?
next prev parent reply other threads:[~2014-09-22 17:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 16:24 [PATCH 0/7] sched: Scale-invariant per-entity load-tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 1/7] sched: Introduce scale-invariant load tracking Morten Rasmussen
2014-09-25 13:48 ` Vincent Guittot
2014-09-25 17:23 ` Morten Rasmussen
2014-09-26 7:36 ` Vincent Guittot
2014-09-26 9:38 ` Morten Rasmussen
2014-10-02 20:34 ` Peter Zijlstra
2014-10-08 11:00 ` Morten Rasmussen
2014-10-08 11:21 ` Vincent Guittot
2014-10-08 13:53 ` Morten Rasmussen
2014-10-08 14:08 ` Vincent Guittot
2014-10-08 14:16 ` Morten Rasmussen
2014-10-08 11:38 ` Vincent Guittot
2014-10-08 14:05 ` Morten Rasmussen
2014-10-10 9:07 ` Peter Zijlstra
2014-10-08 0:50 ` Yuyang Du
2014-10-08 12:54 ` Dietmar Eggemann
2014-10-10 9:16 ` Peter Zijlstra
2014-10-10 9:14 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 2/7] cpufreq: Architecture specific callback for frequency changes Morten Rasmussen
2014-10-08 6:07 ` Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 0/2] introduce capacity_ops to CFS Mike Turquette
2014-10-08 6:26 ` [PATCH RFC 1/2] sched: cfs: introduce capacity_ops Mike Turquette
2014-10-08 8:37 ` Peter Zijlstra
[not found] ` <20141008232836.4379.3339@quantum>
2014-10-09 9:00 ` Peter Zijlstra
[not found] ` <20141009173433.4379.58492@quantum>
2014-10-09 19:00 ` Peter Zijlstra
2014-10-08 6:26 ` [PATCH RFC 2/2] cpufreq: arm_big_little: provide cpu capacity Mike Turquette
2014-10-08 15:48 ` Morten Rasmussen
[not found] ` <20141008223732.4379.78047@quantum>
2014-10-09 9:02 ` Peter Zijlstra
[not found] ` <20141009172513.4379.56718@quantum>
2014-10-09 17:38 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 3/7] arm: Frequency invariant scheduler load-tracking support Morten Rasmussen
2014-09-22 16:24 ` [PATCH 4/7] arm: Micro-architecture invariant load tracking support Morten Rasmussen
2014-09-22 16:24 ` [PATCH 5/7] sched: Implement usage tracking Morten Rasmussen
2014-09-22 16:24 ` [PATCH 6/7] sched: Make sched entity usage tracking scale-invariant Morten Rasmussen
2014-09-22 17:13 ` bsegall
2014-09-23 13:35 ` Morten Rasmussen
2014-10-02 21:04 ` Peter Zijlstra
2014-09-22 16:24 ` [PATCH 7/7] sched: Track sched_entity usage contributions Morten Rasmussen
2014-09-22 17:09 ` bsegall [this message]
2014-09-23 13:59 ` Morten Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xm267g0vlgyx.fsf@sword-of-the-dawn.mtv.corp.google.com \
--to=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=mturquette@linaro.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).