From: Junio C Hamano <gitster@pobox.com>
To: Joe Perches <joe@perches.com>
Cc: git@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] git-send-email: Add ability to cc: any "trailers" from commit message
Date: Wed, 31 Aug 2016 11:11:13 -0700 [thread overview]
Message-ID: <xmqqlgzc24hq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1472666194.4176.17.camel@perches.com> (Joe Perches's message of "Wed, 31 Aug 2016 10:56:34 -0700")
Joe Perches <joe@perches.com> writes:
> On Wed, 2016-08-31 at 10:54 -0700, Junio C Hamano wrote:
>> Joe Perches <joe@perches.com> writes:
>>
>> >
>> > Many commits have various forms of trailers similar to
>> > "Acked-by: Name <address>" and "Reported-by: Name <address>"
>> >
>> > Add the ability to cc these trailers when using git send-email.
>> I thought you were asking what we call these "<token> followed by
>> <colon>" at the end of the log message, and "footers or trailers"
>> was the answer.
>>
>> I do not have a strong objection against limiting to "-by:" lines;
>> for one thing, it would automatically avoid having to worry about
>> "Bug-ID:" and other trailers that won't have e-mail address at all.
>>
>> But if you are _only_ picking up "-by:" lines, then calling this
>> option "trailers" is way too wide and confusing. I do not think
>> there is any specific name for "-by:" lines, though. Perhaps you
>> would need to invent some name that has "-by" as a substring.
>>
>> "any-by"? or just "by"? I dunno.
>
> Signatures?
Helped-by: and Reported-by: are often written by the author of the
patch and not by those who helped or reported, so calling them signatures
imply the author is forging them, too ;-)
I dunno.
Any name that hints that this applies only to the trailers that ends
with "-by" is fine but "Signatures-by" does not sound very
grammatical.
next prev parent reply other threads:[~2016-08-31 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 20:18 [PATCH] git-send-email: Add ability to cc: any "trailers" from commit message Joe Perches
2016-08-31 17:54 ` Junio C Hamano
2016-08-31 17:56 ` Joe Perches
2016-08-31 18:11 ` Junio C Hamano [this message]
2016-08-31 18:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqlgzc24hq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).