From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDF7C46470 for ; Wed, 8 Aug 2018 11:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6561621708 for ; Wed, 8 Aug 2018 11:10:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6561621708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726961AbeHHN3f (ORCPT ); Wed, 8 Aug 2018 09:29:35 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48916 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726744AbeHHN3e (ORCPT ); Wed, 8 Aug 2018 09:29:34 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w78B9nNH117866 for ; Wed, 8 Aug 2018 07:10:21 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kqv0hgf3w-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 08 Aug 2018 07:10:21 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Aug 2018 12:10:18 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 8 Aug 2018 12:10:15 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w78BAEOJ31326214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Aug 2018 11:10:14 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28D3142049; Wed, 8 Aug 2018 14:10:23 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CBF124203F; Wed, 8 Aug 2018 14:10:22 +0100 (BST) Received: from localhost (unknown [9.152.212.90]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 8 Aug 2018 14:10:22 +0100 (BST) Date: Wed, 8 Aug 2018 13:10:13 +0200 From: Vasily Gorbik To: Heiko Carstens Cc: Masahiro Yamada , Michal Marek , Martin Schwidefsky , Steven Rostedt , Ingo Molnar , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 4/4] s390/ftrace: add -mfentry and -mnop-mcount support References: <20180807053017.GA6613@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180807053017.GA6613@osiris> X-TM-AS-GCONF: 00 x-cbid: 18080811-0012-0000-0000-00000296E225 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18080811-0013-0000-0000-000020C9EC7D Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-08_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808080115 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 07:30:17AM +0200, Heiko Carstens wrote: > On Mon, Aug 06, 2018 at 03:17:47PM +0200, Vasily Gorbik wrote: > > Utilize -mfentry and -mnop-mcount gcc options together with > > -mrecord-mcount to get compiler generated calls to the profiling functions > > as nops which are compatible with current -mhotpatch=0,3 approach. At the > > same time -mrecord-mcount enables __mcount_loc section generation by > > the compiler which allows to avoid using scripts/recordmcount.pl script. > > > > Signed-off-by: Vasily Gorbik > > --- > > arch/s390/Kconfig | 2 ++ > > arch/s390/Makefile | 16 +++++++++------- > > arch/s390/include/asm/ftrace.h | 6 +++--- > > arch/s390/kernel/ftrace.c | 2 +- > > arch/s390/kernel/mcount.S | 2 +- > > 5 files changed, 16 insertions(+), 12 deletions(-) > > Do you have numbers which tell how much this reduces the compile time of > the kernel on s390? I assume this change makes quite some difference. > Very roughly, best time across several runs. With -j24 on 24 core lpar with -mfentry -mrecord-mcount etc real 0m54.748s user 12m32.041s sys 1m17.778s vs -mhotpatch=0,3 + scripts/recordmcount.pl: real 0m56.752s user 12m52.386s sys 1m35.873s