From: Jes Sorensen <jes@sgi.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Dave Jones <davej@redhat.com>,
pfg@sgi.com, Linux Kernel <linux-kernel@vger.kernel.org>,
tony.luck@intel.com, linux-ia64@vger.kernel.org
Subject: Re: [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3
Date: 19 Jan 2006 04:54:00 -0500 [thread overview]
Message-ID: <yq0vewg7dc7.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20060119032423.GI19398@stusta.de>
>>>>> "Adrian" == Adrian Bunk <bunk@stusta.de> writes:
Adrian> On Tue, Jan 17, 2006 at 06:55:21PM -0500, Dave Jones wrote:
>> kernel/drivers/serial/ioc3_serial.ko needs unknown symbol
>> ioc3_unregister_submodule
>>
>> CONFIG_SERIAL_SGI_IOC3=m CONFIG_SGI_IOC3=m
Adrian> The untested patch below should fix it.
Actually I think this is more appropriate so we don't end up with 17
cases that add drivers/sn to the build lib.
Dave, does this solve the problem?
Cheers,
Jes
Include drivers/sn when CONFIG_IA64_SGI_SN2 or CONFIG_IA64_GENERIC
is enabled.
Signed-off-by: Jes Sorensen <jes@sgi.com>
----
arch/ia64/Kconfig | 3 +++
drivers/Makefile | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/ia64/Kconfig
===================================================================
--- linux-2.6.orig/arch/ia64/Kconfig
+++ linux-2.6/arch/ia64/Kconfig
@@ -374,6 +374,9 @@
To use this option, you have to ensure that the "/proc file system
support" (CONFIG_PROC_FS) is enabled, too.
+config SGI_SN
+ def_bool y if (IA64_SGI_SN2 || IA64_GENERIC)
+
source "drivers/firmware/Kconfig"
source "fs/Kconfig.binfmt"
Index: linux-2.6/drivers/Makefile
===================================================================
--- linux-2.6.orig/drivers/Makefile
+++ linux-2.6/drivers/Makefile
@@ -69,7 +69,7 @@
obj-$(CONFIG_CPU_FREQ) += cpufreq/
obj-$(CONFIG_MMC) += mmc/
obj-$(CONFIG_INFINIBAND) += infiniband/
-obj-$(CONFIG_SGI_IOC4) += sn/
+obj-$(CONFIG_SGI_SN) += sn/
obj-y += firmware/
obj-$(CONFIG_CRYPTO) += crypto/
obj-$(CONFIG_SUPERH) += sh/
next prev parent reply other threads:[~2006-01-19 9:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 23:55 2.6.16rc1 ia64 missing symbol Dave Jones
2006-01-18 11:02 ` Jes Sorensen
2006-01-19 0:21 ` Dave Jones
2006-01-19 3:24 ` [2.6 patch] drivers/sn/ must be entered for CONFIG_SGI_IOC3 Adrian Bunk
2006-01-19 9:54 ` Jes Sorensen [this message]
2006-01-19 16:09 ` Adrian Bunk
2006-01-20 2:29 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0vewg7dc7.fsf@jaguar.mkp.net \
--to=jes@sgi.com \
--cc=bunk@stusta.de \
--cc=davej@redhat.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).