From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202AbaG1TDo (ORCPT ); Mon, 28 Jul 2014 15:03:44 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27310 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbaG1TDn (ORCPT ); Mon, 28 Jul 2014 15:03:43 -0400 To: KY Srinivasan Cc: "Martin K. Petersen" , Sitsofe Wheeler , Christoph Hellwig , "gregkh\@linuxfoundation.org" , "linux-kernel\@vger.kernel.org" , "devel\@linuxdriverproject.org" , "ohering\@suse.com" , "apw\@canonical.com" , "jasowang\@redhat.com" , "jbottomley\@parallels.com" , "linux-scsi\@vger.kernel.org" Subject: Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests From: "Martin K. Petersen" Organization: Oracle Corporation References: <20140724122223.GA31798@sucs.org> <20140724153612.GA23648@sucs.org> <16fea5bb87ba47019527cee788e07a72@BY2PR0301MB0711.namprd03.prod.outlook.com> <43306901b1dc4e5dbe014a431e0935ea@BY2PR0301MB0711.namprd03.prod.outlook.com> Date: Mon, 28 Jul 2014 15:02:46 -0400 In-Reply-To: <43306901b1dc4e5dbe014a431e0935ea@BY2PR0301MB0711.namprd03.prod.outlook.com> (KY Srinivasan's message of "Mon, 28 Jul 2014 18:50:56 +0000") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "KY" == KY Srinivasan writes: KY, KY> "At the time thin-provisioning was defined, the discovery KY> information was first proposed in READ CAPACITY 16 command. And then KY> moved into the new dedicated VPD page - B2h. You can see the KY> information reported in this VPD page is richer than READ CAPACITY KY> 16 command. As this transition happened during we added the feature, KY> Windows uses the newer method that based on VPD page B2h. It looks KY> Linux tries to use both new and old method which is weird to me." The READ CAPACITY(16) response is not optional. SBC3r36 section 4.7.3.3 Thin provisioned logical unit: The device server in a thin provisioned logical unit shall set: a) the LBPME bit to one in the READ CAPACITY (16) parameter data (see 5.16.2); and b) the PROVISIONING TYPE field to 010b (i.e., thin provisioned) in the Logical Block Provisioning VPD page (see 6.6.4). That's a "shall". The LBP VPD elaborates on the provisioning type, commands preference, etc. But it's all gated by LBPME=1 in the READ CAPACITY(16) response. -- Martin K. Petersen Oracle Linux Engineering