From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: skashyap@marvell.com, jhasan@marvell.com,
GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, himanshu.madhani@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
SeongJae Park <sjpark@amazon.de>
Subject: Re: [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts_cleanup()' return value assignment
Date: Tue, 22 Jun 2021 22:05:25 -0400 [thread overview]
Message-ID: <yq135t9s5cy.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210618164514.6299-1-sj38.park@gmail.com> (SeongJae Park's message of "Fri, 18 Jun 2021 16:45:14 +0000")
SeongJae,
> Commit 122c81c563b0 ("scsi: bnx2fc: Return failure if io_req is
> already in ABTS processing") made 'bnx2fc_eh_abort()' to return
> 'FAILED' when 'io_req' is alrady in ABTS processing, regardless of the
> return value of 'bnx2fc_abts_cleanup()'. But, it left the assignment
> of the return value of 'bnx2fc_abts_cleanup()' to 'rc', which is
> meaningless now. This commit removes it.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-06-23 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 16:45 [PATCH] scsi: bnx2fc: Remove meaningless 'bnx2fc_abts_cleanup()' return value assignment SeongJae Park
2021-06-21 5:23 ` [EXT] " Saurav Kashyap
2021-06-23 2:05 ` Martin K. Petersen [this message]
2021-06-29 4:10 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq135t9s5cy.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=jhasan@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).