From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753547AbdJaP5R (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Oct 2017 11:57:17 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:51238 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751524AbdJaP5P (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Oct 2017 11:57:15 -0400
To: Kees Cook <keescook@chromium.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
        John Garry <john.garry@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        Jack Wang <jinpu.wang@profitbricks.com>, lindar_liu@usish.com,
        Jens Axboe <axboe@fb.com>, Hannes Reinecke <hare@suse.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Benjamin Block <bblock@linux.vnet.ibm.com>,
        Baoyou Xie <baoyou.xie@linaro.org>,
        Wei Yongjun <weiyongjun1@huawei.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sas: Convert timers to use timer_setup()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20171025100800.GA145125@beast>
Date: Tue, 31 Oct 2017 11:56:43 -0400
In-Reply-To: <20171025100800.GA145125@beast> (Kees Cook's message of "Wed, 25
        Oct 2017 03:08:00 -0700")
Message-ID: <yq14lqfb9ac.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Kees,

> In preparation for unconditionally passing the struct timer_list
> pointer to all timer callbacks, switch to using the new timer_setup()
> and from_timer() to pass the timer pointer explicitly. This requires
> adding a pointer to hold the timer's target task, as there isn't a
> link back from slow_task.

Would be good to get John and Jack to take a closer look...

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering