From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0FAC433FF for ; Thu, 8 Aug 2019 02:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BD4B21743 for ; Thu, 8 Aug 2019 02:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="m3Fzm81q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389603AbfHHCQw (ORCPT ); Wed, 7 Aug 2019 22:16:52 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:51136 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727230AbfHHCQv (ORCPT ); Wed, 7 Aug 2019 22:16:51 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x782E9DI156691; Thu, 8 Aug 2019 02:16:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=gSFX7C7laNkAuh/KpAxHJ7SaNxF6mJAaI1qL2c5sLMk=; b=m3Fzm81q860KvdZ+5gUMpO4lGjGEDVs4UTkdCG4bFGyV324E0/Ja6152hqytC27Xvx+m WVPEEqLxs/BbQiNjg0PfMRtyGcBea2SL0cq6W1oRtPDm+VDCXBhcjF+Jxhq/AH5O74u7 hfdr8DGKXfLJC7DKDpftr2ydiclB+qEI6sLMj93nSRYD7cJrSezBUYpLzLiORVUeE7de dxATYTMtnwFRGXd9OQQkKTQGrvOiPWoBxDwp7I73sVUnIdSzHEKVU1V1k6PASNY2/vO1 NjeFgnA+T4mw5JPKgORhTIhe/4iNd7KFwN2pbOvTztSyMb8He0xfp2upgozYjhJCr1Ss ag== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2u527pykuk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2019 02:16:46 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x782D17F022671; Thu, 8 Aug 2019 02:16:46 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2u763jjqav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Aug 2019 02:16:45 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x782Gipq015007; Thu, 8 Aug 2019 02:16:44 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Aug 2019 19:16:43 -0700 To: Colin King Cc: Jack Wang , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190731222214.15720-1-colin.king@canonical.com> Date: Wed, 07 Aug 2019 22:16:41 -0400 In-Reply-To: <20190731222214.15720-1-colin.king@canonical.com> (Colin King's message of "Wed, 31 Jul 2019 23:22:14 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9342 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=920 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908080021 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9342 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=977 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908080021 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > There are several occasions where variable rc is being initialized > with a value that is never read and error is being re-assigned a > little later on. Clean up the code by removing rc entirely and > just returning the return value from the call to pm8001_issue_ssp_tmf Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering