From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755078AbcKVD3m (ORCPT ); Mon, 21 Nov 2016 22:29:42 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:45173 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718AbcKVD3l (ORCPT ); Mon, 21 Nov 2016 22:29:41 -0500 To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Anil Gurumurthy , Sudarsana Kalluru , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions From: "Martin K. Petersen" Organization: Oracle Corporation References: <20161116151445.3208739-1-arnd@arndb.de> Date: Mon, 21 Nov 2016 22:29:27 -0500 In-Reply-To: <20161116151445.3208739-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 16 Nov 2016 16:14:27 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Arnd" == Arnd Bergmann writes: Arnd> These two macros cause lots of warnings with gcc-7: Arnd> drivers/scsi/bfa/bfa_svc.c: In function 'bfa_fcxp_meminfo': Arnd> drivers/scsi/bfa/bfa_svc.c:521:103: error: '*' in boolean context, Arnd> suggest '&&' instead [-Werror=int-in-bool-context] Arnd> Using inline functions makes them much more readable and avoids Arnd> the warnings. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering