From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbdJaPvX (ORCPT ); Tue, 31 Oct 2017 11:51:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46655 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbdJaPvU (ORCPT ); Tue, 31 Oct 2017 11:51:20 -0400 To: Kees Cook Cc: "Martin K. Petersen" , QLogic-Storage-Upstream@qlogic.com, "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla4xxx: Convert timers to use timer_setup() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20171025100743.GA145111@beast> Date: Tue, 31 Oct 2017 11:51:11 -0400 In-Reply-To: <20171025100743.GA145111@beast> (Kees Cook's message of "Wed, 25 Oct 2017 03:07:43 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Cavium folks (for good measure): Please review! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering