From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC211C32792 for ; Tue, 1 Oct 2019 02:48:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADDA720842 for ; Tue, 1 Oct 2019 02:48:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="jECCMiz6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732270AbfJACsU (ORCPT ); Mon, 30 Sep 2019 22:48:20 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:34226 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726504AbfJACsT (ORCPT ); Mon, 30 Sep 2019 22:48:19 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912j9JD073543; Tue, 1 Oct 2019 02:48:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=YpRiIhlIid3LYOYkXp6iDEMgHa7do1U+KOrW141b9k4=; b=jECCMiz6EziGE9RJjLyYyJO4jOvmwIL6/s6CTk80yDnfDkFoUfkgsPA54VN7K8yAyYNO FoHKI1yBT2/0czbYXmbYtMDK9Ouewz46a7UQkVLt1v0QWaAAzrNow6lrnpNH8DzEHBB5 m+TZGJOS5pyycvkSfh7olvKauW0cmf4rlbLLsLy4n18gN000FnWZNDnTLXQ3QQo68Y6Y zbsyg86M0Hj2n5zvSu0ODg2sYkW6a1hE1T5UYJJWTkbteMINuJZrjsTGMlNx3HMYopO/ FJqTNDkgqjomV4t+R0D88yXyn45Zsa0J/M6DgyGhsyHog4JuS4ko19Op0F8Nuf/u9/uy UA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2v9yfq2ug7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:48:13 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912hhEh018158; Tue, 1 Oct 2019 02:46:12 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2vbmpxgr2m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:46:12 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x912kAUh029370; Tue, 1 Oct 2019 02:46:10 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Sep 2019 19:46:10 -0700 To: Colin King Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: fnic: make array dev_cmd_err static const, makes object smaller From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190906163945.3889-1-colin.king@canonical.com> Date: Mon, 30 Sep 2019 22:46:07 -0400 In-Reply-To: <20190906163945.3889-1-colin.king@canonical.com> (Colin King's message of "Fri, 6 Sep 2019 17:39:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=901 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010027 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010027 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Don't populate the array dev_cmd_err on the stack but instead make it > static const. Makes the object code smaller by 80 bytes. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering