linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi:ufs: remove duplicate include in ufshcd
@ 2021-03-06 11:47 menglong8.dong
  2021-03-09 10:07 ` Bean Huo
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: menglong8.dong @ 2021-03-06 11:47 UTC (permalink / raw)
  To: cang
  Cc: alim.akhtar, avri.altman, jejb, martin.petersen, stanley.chu,
	beanhuo, jaegeuk, asutoshd, linux-scsi, linux-kernel,
	Zhang Yunkai

From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'blkdev.h' included in 'ufshcd.c' is duplicated.
It is also included in the 18th line.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 77161750c9fb..9a564b6fd092 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -24,7 +24,6 @@
 #include "ufs_bsg.h"
 #include "ufshcd-crypto.h"
 #include <asm/unaligned.h>
-#include <linux/blkdev.h>
 
 #define CREATE_TRACE_POINTS
 #include <trace/events/ufs.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd
  2021-03-06 11:47 [PATCH] scsi:ufs: remove duplicate include in ufshcd menglong8.dong
@ 2021-03-09 10:07 ` Bean Huo
  2021-03-10  2:49 ` Martin K. Petersen
  2021-03-16  3:14 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Bean Huo @ 2021-03-09 10:07 UTC (permalink / raw)
  To: menglong8.dong, cang
  Cc: alim.akhtar, avri.altman, jejb, martin.petersen, stanley.chu,
	beanhuo, jaegeuk, asutoshd, linux-scsi, linux-kernel,
	Zhang Yunkai

On Sat, 2021-03-06 at 03:47 -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> 
> 
> 'blkdev.h' included in 'ufshcd.c' is duplicated.
> 
> It is also included in the 18th line.
> 
> 
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
Reviewed-by: Bean Huo <beanhuo@micron.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd
  2021-03-06 11:47 [PATCH] scsi:ufs: remove duplicate include in ufshcd menglong8.dong
  2021-03-09 10:07 ` Bean Huo
@ 2021-03-10  2:49 ` Martin K. Petersen
  2021-03-16  3:14 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2021-03-10  2:49 UTC (permalink / raw)
  To: menglong8.dong
  Cc: cang, alim.akhtar, avri.altman, jejb, martin.petersen,
	stanley.chu, beanhuo, jaegeuk, asutoshd, linux-scsi,
	linux-kernel, Zhang Yunkai


> 'blkdev.h' included in 'ufshcd.c' is duplicated.  It is also included
> in the 18th line.

Applied to 5.13/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] scsi:ufs: remove duplicate include in ufshcd
  2021-03-06 11:47 [PATCH] scsi:ufs: remove duplicate include in ufshcd menglong8.dong
  2021-03-09 10:07 ` Bean Huo
  2021-03-10  2:49 ` Martin K. Petersen
@ 2021-03-16  3:14 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2021-03-16  3:14 UTC (permalink / raw)
  To: menglong8.dong, cang
  Cc: Martin K . Petersen, jejb, avri.altman, asutoshd, linux-scsi,
	Zhang Yunkai, linux-kernel, alim.akhtar, beanhuo, jaegeuk,
	stanley.chu

On Sat, 6 Mar 2021 03:47:06 -0800, menglong8.dong@gmail.com wrote:

> 'blkdev.h' included in 'ufshcd.c' is duplicated.
> It is also included in the 18th line.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi:ufs: remove duplicate include in ufshcd
      https://git.kernel.org/mkp/scsi/c/b4388e3db56a

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] scsi: ufs: Remove duplicate include in ufshcd
  2022-04-26 10:45 [PATCH] scsi: ufs: Remove " Wan Jiabing
  2022-04-26 12:10 ` Avri Altman
  2022-04-26 12:31 ` Martin K. Petersen
@ 2022-05-03  0:51 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2022-05-03  0:51 UTC (permalink / raw)
  To: James E.J. Bottomley, Wan Jiabing, linux-kernel, Avri Altman,
	Adrian Hunter, Daejun Park, Can Guo, Asutosh Das, Bean Huo,
	Bart Van Assche, Alim Akhtar, linux-scsi
  Cc: Martin K . Petersen

On Tue, 26 Apr 2022 18:45:07 +0800, Wan Jiabing wrote:

> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
> 
> The include is in line 14. Remove the duplicated here.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ufs: Remove duplicate include in ufshcd
      https://git.kernel.org/mkp/scsi/c/8ad8edd2fbae

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] scsi: ufs: Remove duplicate include in ufshcd
  2022-04-26 10:45 [PATCH] scsi: ufs: Remove " Wan Jiabing
  2022-04-26 12:10 ` Avri Altman
@ 2022-04-26 12:31 ` Martin K. Petersen
  2022-05-03  0:51 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2022-04-26 12:31 UTC (permalink / raw)
  To: Wan Jiabing
  Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
	Martin K. Petersen, Bart Van Assche, Bean Huo, Daejun Park,
	Adrian Hunter, Can Guo, Asutosh Das, linux-scsi, linux-kernel


Wan,

> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
>
> The include is in line 14. Remove the duplicated here.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH] scsi: ufs: Remove duplicate include in ufshcd
  2022-04-26 10:45 [PATCH] scsi: ufs: Remove " Wan Jiabing
@ 2022-04-26 12:10 ` Avri Altman
  2022-04-26 12:31 ` Martin K. Petersen
  2022-05-03  0:51 ` Martin K. Petersen
  2 siblings, 0 replies; 8+ messages in thread
From: Avri Altman @ 2022-04-26 12:10 UTC (permalink / raw)
  To: Wan Jiabing, Alim Akhtar, James E.J. Bottomley,
	Martin K. Petersen, Bart Van Assche, Bean Huo, Daejun Park,
	Adrian Hunter, Can Guo, Asutosh Das, linux-scsi, linux-kernel

 
> Fix following checkincludes warning:
> drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.
> 
> The include is in line 14. Remove the duplicated here.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] scsi: ufs: Remove duplicate include in ufshcd
@ 2022-04-26 10:45 Wan Jiabing
  2022-04-26 12:10 ` Avri Altman
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Wan Jiabing @ 2022-04-26 10:45 UTC (permalink / raw)
  To: Alim Akhtar, Avri Altman, James E.J. Bottomley,
	Martin K. Petersen, Bart Van Assche, Bean Huo, Daejun Park,
	Adrian Hunter, Can Guo, Asutosh Das, linux-scsi, linux-kernel
  Cc: Wan Jiabing

Fix following checkincludes warning:
drivers/scsi/ufs/ufshcd.c: linux/nls.h is included more than once.

The include is in line 14. Remove the duplicated here.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1b87f26b5193..73b3dfffabaa 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -20,7 +20,6 @@
 #include <linux/delay.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
-#include <linux/nls.h>
 #include <linux/regulator/consumer.h>
 #include <scsi/scsi_cmnd.h>
 #include <scsi/scsi_dbg.h>
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-05-04 10:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-06 11:47 [PATCH] scsi:ufs: remove duplicate include in ufshcd menglong8.dong
2021-03-09 10:07 ` Bean Huo
2021-03-10  2:49 ` Martin K. Petersen
2021-03-16  3:14 ` Martin K. Petersen
2022-04-26 10:45 [PATCH] scsi: ufs: Remove " Wan Jiabing
2022-04-26 12:10 ` Avri Altman
2022-04-26 12:31 ` Martin K. Petersen
2022-05-03  0:51 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).