From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754767AbdKGD7c (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 22:59:32 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:35414 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752650AbdKGD7a (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 22:59:30 -0500
To: Jitendra Bhivare <jitendra.bhivare@broadcom.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>, jejb@linux.vnet.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Subramanian Seetharaman <subbu.seetharaman@broadcom.com>,
        Ketan Mukadam <ketan.mukadam@broadcom.com>
Subject: Re: [PATCH v2] scsi: be2iscsi: Use kasprintf
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <1507736174-13089-1-git-send-email-himanshujha199640@gmail.com>
        <02ee3723e44b953558a3ba3100ecabaa@mail.gmail.com>
Date: Mon, 06 Nov 2017 22:59:22 -0500
In-Reply-To: <02ee3723e44b953558a3ba3100ecabaa@mail.gmail.com> (Jitendra
        Bhivare's message of "Mon, 6 Nov 2017 10:31:22 +0530")
Message-ID: <yq1bmke3fj9.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Jitendra,

>> Use kasprintf instead of combination of kmalloc and sprintf.
>> Also, remove BEISCSI_MSI_NAME macro used to specify size of string as
>> kasprintf handles size computations.
>>
>> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

> Reviewed-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com>

Applied to 4.15/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering