From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] megaraid_sas: Fix probing cards without io port
Date: Mon, 08 Aug 2016 22:03:06 -0400 [thread overview]
Message-ID: <yq1bn12u2at.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160806063734.31083-1-yinghai@kernel.org> (Yinghai Lu's message of "Fri, 5 Aug 2016 23:37:34 -0700")
>>>>> "Yinghai" == Yinghai Lu <yinghai@kernel.org> writes:
> Found one megaraid_sas HBA probe fails,
>
> [ 187.235190] scsi host2: Avago SAS based MegaRAID driver
> [ 191.112365] megaraid_sas 0000:89:00.0: BAR 0: can't reserve [io 0x0000-0x00ff]
> [ 191.120548] megaraid_sas 0000:89:00.0: IO memory region busy!
> and the card has resource like,
> [ 125.097714] pci 0000:89:00.0: [1000:005d] type 00 class 0x010400
> [ 125.104446] pci 0000:89:00.0: reg 0x10: [io 0x0000-0x00ff]
> [ 125.110686] pci 0000:89:00.0: reg 0x14: [mem 0xce400000-0xce40ffff 64bit]
> [ 125.118286] pci 0000:89:00.0: reg 0x1c: [mem 0xce300000-0xce3fffff 64bit]
> [ 125.125891] pci 0000:89:00.0: reg 0x30: [mem 0xce200000-0xce2fffff pref]
> that does not io port resource allocated from BIOS, and kernel can not assign
> one as io port shortage.
>
> The driver is only looking for MEM, and should not fail.
> It turns out megasas_init_fw() etc are using bar index as mask.
> index 1 is used as mask 1, so that pci_request_selected_regions()
> is trying to request BAR0 instead of BAR1.
> Fix all related reference.
Kashyap? Sumit?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-08-09 2:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 6:37 [PATCH] megaraid_sas: Fix probing cards without io port Yinghai Lu
2016-08-09 2:03 ` Martin K. Petersen [this message]
2016-08-09 17:52 ` Kashyap Desai
2016-08-11 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bn12u2at.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).