From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Wei Li <liwei213@huawei.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Dmitry Shmidt <dimitrysh@google.com>
Subject: Re: [RFC][PATCH v2] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC
Date: Tue, 23 Oct 2018 22:47:21 -0400 [thread overview]
Message-ID: <yq1d0s0f4cm.fsf@oracle.com> (raw)
In-Reply-To: <1540254710-26936-1-git-send-email-john.stultz@linaro.org> (John Stultz's message of "Mon, 22 Oct 2018 17:31:50 -0700")
John,
Thanks for tweaking this.
> Not sure if this is the preferred way of scoping the quirk to
> the controller or not. Feedback would be greatly appreciated!
I think my preference would be to add:
UFS_FIX(UFS_VENDOR_SKHYNIX, "hB8aL1",
UFS_DEVICE_QUIRK_HOST_VS_DEBUG),
to ufs_fixups[] and then key off of that in the driver. That's how we do
it in SCSI but the UFS folks may have a different opinion.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-10-24 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 0:31 [RFC][PATCH v2] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC John Stultz
2018-10-24 2:47 ` Martin K. Petersen [this message]
2018-10-24 3:02 ` John Stultz
2018-10-24 3:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0s0f4cm.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dimitrysh@google.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).