From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, ryan@finnie.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
Don Brace <don.brace@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
esc.storagedev@microsemi.com (open list:HEWLETT-PACKARD SMART
ARRAY RAID DRIVER (hpsa)),
linux-scsi@vger.kernel.org (open list:HEWLETT-PACKARD SMART
ARRAY RAID DRIVER (hpsa)),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH V5] scsi: hpsa: disable device during shutdown
Date: Tue, 05 Jun 2018 21:19:57 -0400 [thread overview]
Message-ID: <yq1d0x4g18i.fsf@oracle.com> (raw)
In-Reply-To: <1527913733-16492-1-git-send-email-okaya@codeaurora.org> (Sinan Kaya's message of "Sat, 2 Jun 2018 00:28:53 -0400")
Sinan,
> 'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during
> shutdown")' has been added to kernel to shutdown pending PCIe port
> service interrupts during reboot so that a newly started kexec kernel
> wouldn't observe pending interrupts.
>
> pcie_port_device_remove() is disabling the root port and switches by
> calling pci_disable_device() after all PCIe service drivers are shutdown.
>
> This has been found to cause crashes on HP DL360 Gen9 machines during
> reboot due to hpsa driver not clearing the bus master bit during the
> shutdown procedure by calling pci_disable_device().
>
> Disable device as part of the shutdown sequence.
Applied to 4.18/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-06-06 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 4:28 [PATCH V5] scsi: hpsa: disable device during shutdown Sinan Kaya
2018-06-06 1:19 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0x4g18i.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=ryan@finnie.org \
--cc=stable@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).