From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:BCACHE (BLOCK LAYER CACHE)"
<linux-bcache@vger.kernel.org>
Subject: Re: [PATCH] bcache: make stripe_size configurable and persistent for hardware raid5/6
Date: Mon, 10 Jan 2022 11:14:29 -0500 [thread overview]
Message-ID: <yq1fspvshbw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <98aa1886-859-abb9-164f-c9eb9be38a91@ewheeler.net> (Eric Wheeler's message of "Sat, 8 Jan 2022 13:51:22 -0800 (PST)")
Eric,
> Ok so `git blame` shows that Kent added this to md/raid5.c in
> c78afc6261b (Kent Overstreet 2013-07-11 22:39:53 -0700 7526)
Yep.
> Do you think we should leave the md-specific
> raid_partial_stripes_expensive setting and require users of RAID
> controllers to set the bit themselves in bcache---or---remove all
> raid_partial_stripes_expensive code and always treat writes as
> "expensive" when `opt_io` is defined?
I'd prefer the latter since that was the very intent of exporting the
device topology in an abstract and protocol-independent fashion.
However, I don't know enough about bcache internals to know whether it
is always the right choice, what the trade-offs are, etc.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-01-10 16:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d3f7fd44-9287-c7fa-ee95-c3b8a4d56c93@suse.de>
2019-06-22 23:16 ` [PATCH] bcache: make stripe_size configurable and persistent for hardware raid5/6 Eric Wheeler
2019-06-23 0:41 ` Martin K. Petersen
2019-06-24 6:57 ` Coly Li
2019-06-24 7:05 ` Coly Li
2019-06-24 18:14 ` Eric Wheeler
2019-06-24 23:24 ` Martin K. Petersen
2019-06-26 0:23 ` Eric Wheeler
2019-06-26 2:50 ` Martin K. Petersen
2019-06-25 1:59 ` Coly Li
2022-01-06 3:29 ` Eric Wheeler
2022-01-06 16:17 ` Coly Li
2022-01-08 0:21 ` Martin K. Petersen
2022-01-08 4:54 ` Eric Wheeler
2022-01-08 21:51 ` Eric Wheeler
2022-01-10 16:14 ` Martin K. Petersen [this message]
2022-01-10 23:30 ` Eric Wheeler
2022-01-11 2:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fspvshbw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bcache@lists.ewheeler.net \
--cc=colyli@suse.de \
--cc=corbet@lwn.net \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).