From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4471FC3279D for ; Wed, 7 Oct 2020 03:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3265207EA for ; Wed, 7 Oct 2020 03:07:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="zZlIDAAd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbgJGDHe (ORCPT ); Tue, 6 Oct 2020 23:07:34 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:39084 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbgJGDHd (ORCPT ); Tue, 6 Oct 2020 23:07:33 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09734uEJ176783; Wed, 7 Oct 2020 03:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=SpqvUTc1JSIevtlxGlR/OvymXNJlO9t3p+BYhnP/fQs=; b=zZlIDAAdd01R+uFTv1qcqE2zH8+bnzlnXthR0QWiJQnuIyHjX75FMC0dgLWc2k7JOoxH RhigwQeHxmjCahQSFTPpHPpHVb8FNGKxtEh1f3y9CGKjLC1xPUkuuvkLGYXi6nZfh3D+ q1C0+GC16FynRfBMdO3mhMg6h+DiS5YFyOUHc9cn5cG6QBN4asIycC+gC+Ji+ZbzMDlV obqWgSpEPP5NktDjETL9f2FkOu4X/HBps8mo4/kOy4nxgJfb+iffMe07DE5AnhpYviFv FCTyQFwpfA9+xDPW8JnYWz50XfY9z4CeKnK/bXqeFpZ7qpZG7Hw37TwhV+6GUAbOqE/6 hA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 33ym34mgc8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 07 Oct 2020 03:07:22 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09734oo3118282; Wed, 7 Oct 2020 03:05:21 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 3410jy1pe9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Oct 2020 03:05:21 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09735LYJ007100; Wed, 7 Oct 2020 03:05:21 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 06 Oct 2020 20:05:20 -0700 To: Liu Shixin Cc: "James E.J. Bottomley" , "Martin K. Petersen" , , Subject: Re: [PATCH -next] scsi: initio: use module_pci_driver to simplify the code From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200917071045.1909320-1-liushixin2@huawei.com> Date: Tue, 06 Oct 2020 23:05:19 -0400 In-Reply-To: <20200917071045.1909320-1-liushixin2@huawei.com> (Liu Shixin's message of "Thu, 17 Sep 2020 15:10:45 +0800") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9766 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=1 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070020 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9766 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 clxscore=1015 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 suspectscore=1 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070020 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Liu, > Use the module_pci_driver() macro to make the code simpler by > eliminating module_init and module_exit calls. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering