From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751119AbcFCDHn (ORCPT ); Thu, 2 Jun 2016 23:07:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:49188 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbcFCDHl (ORCPT ); Thu, 2 Jun 2016 23:07:41 -0400 To: Christoph Hellwig Cc: Shaohua Li , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, sitsofe@yahoo.com, snitzer@redhat.com, axboe@fb.com, martin.petersen@oracle.com, Kernel-team@fb.com Subject: Re: [PATCH] block: correctly fallback for zeroout From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160526180813.GA49039@shli-mbp.local> <20160529064728.GA14383@infradead.org> Date: Thu, 02 Jun 2016 23:06:56 -0400 In-Reply-To: <20160529064728.GA14383@infradead.org> (Christoph Hellwig's message of "Sat, 28 May 2016 23:47:28 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Christoph" == Christoph Hellwig writes: Christoph> As part of that I also removed the strange EOPNOTSUPP ignore, Christoph> but Mike reverted it just because it changed something in the Christoph> dm testsuite. Mike? Christoph> I still believe we should never ignore it in this helper, and Christoph> only do so in callers that believe it's the right thing. Yeah. I really wish EOPNOTSUPP would just go away except for ioctl callers. Now that we have real bi_error I don't understand why we need it. -- Martin K. Petersen Oracle Linux Engineering