From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbcBLQ6N (ORCPT ); Fri, 12 Feb 2016 11:58:13 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25512 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbcBLQ6M (ORCPT ); Fri, 12 Feb 2016 11:58:12 -0500 To: James Bottomley Cc: Tyrel Datwyler , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, jthumshirn@suse.de, manoj@linux.vnet.ibm.com Subject: Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines From: "Martin K. Petersen" Organization: Oracle Corporation References: <1455154348-3226-1-git-send-email-tyreld@linux.vnet.ibm.com> <1455154348-3226-4-git-send-email-tyreld@linux.vnet.ibm.com> <1455295395.2396.22.camel@HansenPartnership.com> <56BE0D7D.3050703@linux.vnet.ibm.com> <1455295989.2396.23.camel@HansenPartnership.com> Date: Fri, 12 Feb 2016 11:57:59 -0500 In-Reply-To: <1455295989.2396.23.camel@HansenPartnership.com> (James Bottomley's message of "Fri, 12 Feb 2016 08:53:09 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "James" == James Bottomley writes: James> OK we need a re-review then ... I'll hold off pushing for now. -- Martin K. Petersen Oracle Linux Engineering